GeezerVison is showing github.com — lib/, bin/: fix signature type, now called *.sig2 by classabbyamp · Pull Request #565 · void-linux/xbps
Conversation
classabbyamp
commented
Aug 8, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Since 8d5c48b, xbps has used a sha1 ASN1 prefix with a sha256 hash, and as of openssl v3, openssl cares about this. This works around that in a compatible way by moving to a second sig file, binpkg.sig2.
For xbps-remove -O and xbps-rindex -r, also clean up obselete .sig files.
Tested
xbps-rindex -S of a package to generate a .sig2
xbps-rindex -r of a package with both .sig and .sig2
xbps-remove -O of a package with both .sig and .sig2 in cache
xbps-install of a package with a .sig2
- upgrade of xbps with this patch applied works (requires a couple minor changes to rebase and apply cleanly on 0.59.1)
- upgrading openssl to v3 and using xbps with it (see this branch)
This will require
- an external signing utility that can sign new versions of
xbps with the old signature format to allow for installation of the fixed version (like this)
- probably some manual intervention for initially signing all packages with the new
.sig2
Questions
- should old
.sigs be removed from the repos?
- are there any infra implications that will need to be updated to deal with the new
.sig2 files? downstream mirrors filtering their rsyncs?
closes #544
fixes #531
fixes #480
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Since 8d5c48b, xbps has used a sha1 ASN1 prefix with a sha256 hash, and
as of openssl v3, openssl cares about this. This works around that in a
compatible way by moving to a second sig file, binpkg.sig2.
For xbps-remove -O and xbps-rindex -r, also clean up obselete .sig files.
caused issues when .xbps existed locally but .sig2 did not.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.