GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib/, bin/: fix signature type, now called *.sig2 by classabbyamp · Pull Request #565 · void-linux/xbps

Conversation

@classabbyamp

@classabbyamp classabbyamp commented Aug 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since 8d5c48b, xbps has used a sha1 ASN1 prefix with a sha256 hash, and as of openssl v3, openssl cares about this. This works around that in a compatible way by moving to a second sig file, binpkg.sig2.

For xbps-remove -O and xbps-rindex -r, also clean up obselete .sig files.

Tested

  • xbps-rindex -S of a package to generate a .sig2
  • xbps-rindex -r of a package with both .sig and .sig2
  • xbps-remove -O of a package with both .sig and .sig2 in cache
  • xbps-install of a package with a .sig2
  • upgrade of xbps with this patch applied works (requires a couple minor changes to rebase and apply cleanly on 0.59.1)
  • upgrading openssl to v3 and using xbps with it (see this branch)

This will require

  1. an external signing utility that can sign new versions of xbps with the old signature format to allow for installation of the fixed version (like this)
  2. probably some manual intervention for initially signing all packages with the new .sig2

Questions

  1. should old .sigs be removed from the repos?
  2. are there any infra implications that will need to be updated to deal with the new .sig2 files? downstream mirrors filtering their rsyncs?

closes #544
fixes #531
fixes #480

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
classabbyamp added 2 commits August 8, 2023 15:37
@classabbyamp
lib/, bin/: fix signature type, now called *.sig2
2356df0
Since 8d5c48b, xbps has used a sha1 ASN1 prefix with a sha256 hash, and
as of openssl v3, openssl cares about this. This works around that in a
compatible way by moving to a second sig file, binpkg.sig2.

For xbps-remove -O and xbps-rindex -r, also clean up obselete .sig files.
@classabbyamp
configure: workaround for openssl3 compat
79bffee
@classabbyamp
classabbyamp force-pushed the sig2 branch from 003d264 to 79bffee Compare August 8, 2023 19:38
@classabbyamp classabbyamp mentioned this pull request Aug 11, 2023
xbps: patch in workaround for openssl3 compat void-linux/void-packages#45557
Merged
@classabbyamp
lib/transaction_fetch.c: don't rely on digest being NULL
51e886b
caused issues when .xbps existed locally but .sig2 did not.
@Duncaen
Duncaen merged commit f68893e into void-linux:master Aug 30, 2023
@classabbyamp
classabbyamp deleted the sig2 branch August 30, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to build xbps xbps signatures use SHA256 hash with SHA1 DigestInfo

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@classabbyamp @Duncaen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.