GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Print install and remove messages below transaction summary by Duncaen · Pull Request #572 · void-linux/xbps

Conversation

@Duncaen

@Duncaen Duncaen commented Sep 17, 2023

Copy link
Copy Markdown
Member

Continuation of #421.

  1. -n does not print the messages at the moment, I don't think breaking the parseable output is a good idea.
  2. removed the callbacks for the message, since its a lot easier to just print and work with the messages from where the transaction is summarized.
  3. removed xbps_cb_messge since its pointless, we can just print the data directly.
  4. simplified the message formatting (removed the big = padding, I think it looks better without, but this is arguable).
[*] Updating repository `https://repo-de.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...

Name           Action    Version           New version            Download size
SDL_gfx        install   -                 2.0.26_2               42KB
OpenXcom       install   -                 1.0_5                  1622KB
GraphicsMagick install   -                 1.3.40_1               85KB

Size to download:             1750KB
Size required on disk:        5247KB
Space available on disk:       810GB

[*] OpenXcom install message:
OpenXcom requires a vanilla version of the original
UFO: Enemy Unknown/X-COM: UFO Defense (any edition).
See /usr/share/doc/openxcom/README.txt for details.


[*] GraphicsMagick install message:
 The libgraphicsmagick-devel package contains the GraphicsMagick PERL
 extension. To install this extension follow the instructions in:

   /usr/share/doc/GraphicsMagick/PerlMagick/README.txt


Do you want to continue? [Y/n]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
icp1994 reacted with thumbs up emoji dmarto reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
Chocimier and others added 9 commits September 16, 2023 16:07
@Chocimier
Expose xbps_cb_message in libxbps
b874f2c
@Chocimier
lib: display install-msgs before transaction
ee0bf13
@Chocimier
lib: skip install-msg seen previously
e39ae4b
@Chocimier
xbps-install, -remove: change formatting of install-msgs
4478378
@Chocimier
lib: don't display package messages during transaction
89c32af
@Duncaen
bin/xbps-{install,remove}: cleanup transaction code function arguments
2a0d57f
@Duncaen
lib: remove xbps_cb_message and message states
e2600c2
@Duncaen
bin/xbps-remove: remove message callbacks
8352e08
@Duncaen
bin/xbps-install: remove message callbacks
52960e8
@Duncaen
Duncaen force-pushed the install-msg branch from f44ea70 to aa0132c Compare September 17, 2023 18:26
Duncaen added 2 commits September 17, 2023 20:29
@Duncaen
bin/xbps-{install,remove}: print install/remove messages
1ac5698
@Duncaen
tests: add tests for install and remove messages
efa8973
@Duncaen
Duncaen force-pushed the install-msg branch from aa0132c to efa8973 Compare September 17, 2023 18:29
@classabbyamp

classabbyamp commented Sep 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

-n does not print the messages at the moment, I don't think breaking the parseable output is a good idea.

I like the idea of putting them on stderr, that should prevent breaking anything that doesn't 2>&1 as discussed on irc, a regular run can be done and no can be chosen if users want to see these messages, as dryrun is probably only used for update checking scripts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Chocimier
Chocimier approved these changes Sep 21, 2023
View reviewed changes

@Chocimier Chocimier left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-n is only mode that shows transaction without root, sometimes I use it for quick look how it would look like. Yet, can't see any good way to include messages there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Duncaen
Duncaen merged commit bbbd792 into void-linux:master Jan 23, 2025
@classabbyamp classabbyamp mentioned this pull request Mar 2, 2025
[Feature request] package news #622
Closed
@classabbyamp classabbyamp mentioned this pull request May 21, 2025
[RFC] Update-specific messages, and install-only INSTALL.msg #559
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Chocimier Chocimier Chocimier approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Duncaen @classabbyamp @Chocimier
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.