GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — move the repository stage into the repodata file by Duncaen · Pull Request #575 · void-linux/xbps

Conversation

@Duncaen

@Duncaen Duncaen commented Oct 28, 2023

Copy link
Copy Markdown
Member

By combining repodata and stage data into a single file its easier to
use remote stagedata when enabled. This also avoids having to come up
with a new mechanism to fetch -stagedata and having to keep -repodata
and -stagedata in sync.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
classabbyamp reacted with eyes emoji
All reactions
  • 👀 1 reaction
github-advanced-security[bot]
github-advanced-security AI found potential problems Oct 28, 2023
View reviewed changes
Comment thread bin/xbps-rindex/index-add.c
}

for (int i = args; i < argc; i++) {
r = index_add_pkg(xhp, index, stage, argv[i], force);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This argument to a file access function is derived from [user input (a command-line argument)](1) and then passed to index_add_pkg(file), which calls xbps_file_sha256(file), which calls xbps_file_sha256_raw(file), which calls open(__file).
Comment thread lib/repo.c
return -ENAMETOOLONG;
}

fd = open(path, O_WRONLY|O_CREAT|O_CLOEXEC, 0660);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This argument to a file access function is derived from [user input (a command-line argument)](1) and then passed to open(__file).
@Duncaen
Duncaen force-pushed the stagedata branch from f49235c to 63d5073 Compare October 31, 2023 23:43
@Duncaen
Duncaen force-pushed the stagedata branch from 5ffa594 to 95bcd80 Compare May 6, 2025 16:11
github-advanced-security[bot]
github-advanced-security AI found potential problems May 6, 2025
View reviewed changes
Comment thread bin/xbps-rindex/index-clean.c
printf("index: removed pkg %s\n", pkgver);
}
xbps_dictionary_get_cstring_nocopy(obj, "filename-sha256", &sha256);
if (xbps_file_sha256_check(path, sha256) != 0)

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This argument to a file access function is derived from [user input (a command-line argument)](1) and then passed to xbps_file_sha256_check(file), which calls xbps_file_sha256_raw(file), which calls open(__file).
Comment thread lib/repo.c
errno = -r;
return NULL;
}
repo->xhp = xhp;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory

A stack address which arrived via a [parameter](1) may be assigned to a non-local variable.
@Duncaen
Duncaen force-pushed the stagedata branch 2 times, most recently from 729b7ab to 5be8009 Compare May 11, 2025 17:03
@Duncaen
Duncaen force-pushed the stagedata branch from 5be8009 to 0175f8c Compare May 19, 2025 17:00
classabbyamp
classabbyamp approved these changes May 19, 2025
View reviewed changes

@classabbyamp classabbyamp left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine overall. is there any function to merge an existing stagedata into a repodata, or is it assumed that the user should unstage before upgrading xbps?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread data/xbps.d.5 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread include/xbps.h.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
Duncaen added 8 commits May 19, 2025 21:07
@Duncaen
lib: move the repository stage into the repodata file
02584df 
By combining repodata and stage data into a single file its easier to
use remote stagedata when enabled. This also avoids having to come up
with a new mechanism to fetch -stagedata and having to keep -repodata
and -stagedata in sync.
@Duncaen
bin/xbps-rindex: move the repository stage into the repodata file
8be8c21
@Duncaen
bin/xbps-query: for -L show if repositories are staged
e8949ee
@Duncaen
tests: move the repository stage into the repodata file
3f0ae8a
@Duncaen
lib: add xbps flag to enable using staged remote repositories
1433031
@Duncaen
bin/xbps-install: add --staging flag
a2344ba
@Duncaen
bin/xbps-query: add --staging flag
9efe510
@Duncaen
bin/xbps-checkvers: add --staging flag
66c0093
@Duncaen
Duncaen force-pushed the stagedata branch from 0175f8c to 66c0093 Compare May 19, 2025 19:07
@Duncaen Duncaen closed this May 20, 2025
@Duncaen Duncaen mentioned this pull request May 21, 2025
xbps-rindex -r Assertion `obj' failed when $arch-repodata is empty #478
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@classabbyamp classabbyamp classabbyamp approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Duncaen @classabbyamp @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.