GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — xbps-fetch: don't url-escape tilde character in path by gmbeard · Pull Request #607 · void-linux/xbps

Conversation

@gmbeard

@gmbeard gmbeard commented Dec 7, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This prevents the tilde (~) character from being escaped as %7e in paths.

For example, this URL didn't previously resolve correctly...

http://www.cs.columbia.edu/~lennox/udptunnel/udptunnel-1.1.tar.gz

Fixes #606

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gmbeard
xbps-fetch: don't url-escape tilde character in path
444e8a3 
This prevents the tilde (`~`) character from being escaped as
`%7e` in paths.

For example, this URL didn't previously resolve correctly...

```
http://www.cs.columbia.edu/~lennox/udptunnel/udptunnel-1.1.tar.gz
```

Fixes void-linux#606
@gmbeard
gmbeard force-pushed the fix/xbps-fetch-tilde-path-character branch from df4f1a0 to 444e8a3 Compare December 8, 2024 14:47
@gmbeard gmbeard changed the title xbps-fetch: don't url-encode tilde character in path xbps-fetch: don't url-escape tilde character in path Dec 8, 2024
@Duncaen
Duncaen merged commit 74f2a92 into void-linux:master Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xbps-fetch: tilde character shouldn't be url-escaped

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gmbeard @Duncaen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.