GeezerVison is showing github.com — feat(framework): support pracht by JoviDeCroock · Pull Request #455 · voidzero-dev/void
Conversation
Note
This PR was authored by GPT6.1-sol and reviewed by Jovi
Summary
Adds pracht (a Preact framework on Vite) as a supported framework. Like Nuxt, Analog and Astro, pracht owns its Cloudflare build: it runs @cloudflare/vite-plugin itself, prerenders with its CLI, and writes a deployable Worker to dist/server/worker.js.
Depends on
pracht's side is JoviDeCroock/pracht#436, which adds the configPath option and lets the Cloudflare build import node:async_hooks.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…re build
Detect pracht from @pracht/adapter-cloudflare and deploy the Worker that
`pracht build` writes to dist/server/worker.js. In dev, wrap pracht's
server entry so cron and queue triggers reach the generated dispatch, and
import Void's env module from the entry so lazily loaded routes can use
void/db on the first request. Framework presets can now set the asset
trailing-slash policy their Worker relies on.
|
Pracht looks cool. I think at this time we are ok making changes and tests to support external frameworks, but we are not looking to add named behavior specific to one framework. For example, happy to expose/refactor APIs, but Void embedding a pracht dev call is not the right time for us yet.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.