GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update the algorithm to handle roles where naming is not supported by joanmarie · Pull Request #53 · w3c/accname

Conversation

@joanmarie

@joanmarie joanmarie commented Jun 18, 2019 •
edited by cookiecrook
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #52

Add a statement to the end of Step 1 ("initialize") stating that if the
root node's role doesn't support naming, return the empty string. At the
present time, this impacts nothing because all roles currently support
naming. If that changes within the ARIA spec, this modification is meant
to accomplish the following:

<span aria-label="bar">foo</span>: The span has no name.

<button><span aria-label="bar">foo</span></button>: The button's
accessible name is "bar" (but the span itself has no name).

In other words, it prohibits generic elements themselves from getting
names, but preserves the name calculation results authors might be
expecting in currently-deployed content.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

scottaohara and a11ydoer reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@joanmarie
Update the algorithm to handle roles where naming is not supported
7cb9537
Add a statement to the end of Step 1 ("initialize") stating that if the
root node's role doesn't support naming, return the empty string. At the
present time, this impacts nothing because all roles currently support
naming. If that changes within the ARIA spec, this modification is meant
to accomplish the following:

<span aria-label="bar">foo</span>: The span has no name.

<button><span aria-label="bar">foo</span>: The button's accessible name
is "bar" (but the span itself has no name).

In other words, it prohibits generic elements themselves from getting
names, but preserves the name calculation results authors might be
expecting in currently-deployed content.
@joanmarie
joanmarie requested review from accdc and jnurthen June 18, 2019 18:49
@joanmarie

joanmarie commented Jun 18, 2019

Copy link
Copy Markdown
Contributor Author

@accdc and @jnurthen: Here is how I think we can keep the AccName spec in harmony with the ARIA spec even with names being prohibited (or unsupported) on generic roles. Please review. Thanks in advance!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joanmarie joanmarie mentioned this pull request Jun 18, 2019
Ensure the ARIA spec and AccName spec remain aligned if we prohibit naming on certain roles #52
Closed
@carmacleod

carmacleod commented Jun 18, 2019

Copy link
Copy Markdown
Contributor

Pretty simple. :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jnurthen jnurthen mentioned this pull request Jun 19, 2019
Prohibit label on certain roles w3c/aria#985
Merged
@joanmarie
Say "prohibits" rather than "does not support" re naming
70c46a0
Also remove "initialize" because step 1 is no longer purely
initialization.

Also add changelog entry.
@joanmarie
joanmarie force-pushed the issue-52 branch from 143ce3a to 70c46a0 Compare June 27, 2019 17:55
@joanmarie
joanmarie merged commit 45dbaa2 into master Jun 27, 2019
@joanmarie
joanmarie deleted the issue-52 branch June 27, 2019 17:59
@jnurthen jnurthen mentioned this pull request Feb 3, 2021
No label if name is prohibited? #99
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@accdc accdc Awaiting requested review from accdc
@jnurthen jnurthen Awaiting requested review from jnurthen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@joanmarie @carmacleod
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.