GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [css-values] Use fetch 'conclude' instead of 'finalize' by noamr · Pull Request #7160 · w3c/csswg-drafts

Conversation

@noamr

@noamr noamr commented Mar 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

[css-values-4] Fetch now exposes 'conclude' instead of 'finalize' which works with a fetch controller - this clarifies that resource timing entries are mapped to a fetch rather than to a response.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
noamr added 2 commits March 20, 2022 14:02
@noamr
[css-values] Use fetch 'conclude' instead of 'finalize'
07e1eee
@noamr
nit
1dda7b8
@noamr noamr mentioned this pull request Mar 20, 2022
Call finalize and report timing automatically on end-of-body whatwg/fetch#1413
Merged
tabatkins
tabatkins reviewed Mar 24, 2022
View reviewed changes
Comment thread css-values-4/Overview.bs
10. [=/Fetch=] |req|, with <var ignore>taskDestination</var> set to |global|, and <var ignore>processResponseConsumeBody</var>
set to the following steps given [=/response=] |res| and Null, failure or byte stream
|byteStream|:
10. Let |controller| be the result of [=/Fetch|fetching=] |req|, with <var ignore>taskDestination</var>

@tabatkins tabatkins Mar 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make a change here, but just fyi, Bikeshed's conjugation support means you could just write [=/fetching=] and it'll link correctly to /fetch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tabatkins
tabatkins merged commit 10f6575 into w3c:main Mar 24, 2022
@tabatkins

tabatkins commented Mar 24, 2022

Copy link
Copy Markdown
Member

Oh and also, for the future, please match the indentation whitespace of the spec you're editting; we use tabs in the CSSWG. If possible, also set your editor to strip line-final whitespace, as it'll cause diff churn the next time I touch the file otherwise.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@noamr

noamr commented Mar 25, 2022

Copy link
Copy Markdown
Collaborator Author

Oh and also, for the future, please match the indentation whitespace of the spec you're editting; we use tabs in the CSSWG. If possible, also set your editor to strip line-final whitespace, as it'll cause diff churn the next time I touch the file otherwise.

Gotcha, I'm working on several specs in parallel and sometimes the settings don't match :)

This was not supposed to be merged yet though - it depends on a fetch PR that wasn't merged yet. I see now that this is my bad since I forgot to put the "depends on" thing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tabatkins

tabatkins commented Mar 25, 2022

Copy link
Copy Markdown
Member

Oh shoot, yeah, you didn't indicate in any way that it was a draft.
noamr reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@noamr

noamr commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator Author

Oh shoot, yeah, you didn't indicate in any way that it was a draft.

My bad, apologies again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tabatkins tabatkins tabatkins left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@noamr @tabatkins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.