GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 📦 new: add context to git commit message by Abhinav-Bansal751 · Pull Request #14 · warengonzaga/magic-commit

Conversation

@Abhinav-Bansal751

@Abhinav-Bansal751 Abhinav-Bansal751 commented Oct 6, 2024

Copy link
Copy Markdown
Contributor

Pull Request

Summary

This PR updates the config.json file to improve the commit message generation logic. The changes include the addition of a new prompt format for better categorization and context in commit messages.

Changes Made

  • Updated the emoji prompt to include a structured format: <emoji> category (context): title..

Related Issues

  • Closes add context to git commit message #1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Abhinav-Bansal751
update config.json
1e8a7f5
@Abhinav-Bansal751

Abhinav-Bansal751 commented Oct 6, 2024

Copy link
Copy Markdown
Contributor Author

@warengonzaga can u please check if its correct.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga
warengonzaga self-requested a review October 6, 2024 10:25
warengonzaga
warengonzaga requested changes Oct 6, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my requested changes. Looks like it needs a complete git message convention. Not sure what to use in (context) or (scope) I think for now let's use file name of staged file. I leave a reference file where you can edit it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread source/utils/config.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga

warengonzaga commented Oct 6, 2024

Copy link
Copy Markdown
Owner

The git commit convention here is my personal convention when building open source projects. I think I have to make a complete specs of my preference.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Abhinav-Bansal751 added 2 commits October 6, 2024 17:06
@Abhinav-Bansal751
Update Openai.js
3154d2c
@Abhinav-Bansal751
Update Openai.js
884d866
@warengonzaga
warengonzaga self-requested a review October 6, 2024 13:55
warengonzaga
warengonzaga requested changes Oct 6, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for the contribution. Could you take a look at my requested changes?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread source/utils/config.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga

warengonzaga commented Oct 6, 2024

Copy link
Copy Markdown
Owner

Kindly fix the conflicting file issue @Abhinav-Bansal751. The best way to do this is to merge the changes from the dev branch and then use a web editor to merge the changes in the dev branch to your copy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga warengonzaga assigned Abhinav-Bansal751 Oct 6, 2024
@warengonzaga warengonzaga added hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR) feature Feature Request (Issue) labels Oct 6, 2024
@warengonzaga warengonzaga changed the title update config.json 📦 new: add context to git commit message Oct 6, 2024
Abhinav-Bansal751 added 2 commits October 6, 2024 23:45
@Abhinav-Bansal751
Merge dev into your-branch-name, conflict resolution pending
475ec59
@Abhinav-Bansal751
Merge branch 'dev' of https://github.com/warengonzaga/magic-commit in…
f430b0a 
…to dev
@warengonzaga
warengonzaga self-requested a review October 7, 2024 04:37
warengonzaga
warengonzaga reviewed Oct 7, 2024
View reviewed changes
Comment thread package-lock.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
warengonzaga
warengonzaga requested changes Oct 7, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly check the comments and click "resolve conversation" if you already updated the code. It should show "outdated" if you made changes. Lastly, I think the best way is to delete the yarn.lock file I can handle the rest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@warengonzaga
Merge branch 'dev' into dev
f64f6cd
@warengonzaga

warengonzaga commented Oct 7, 2024

Copy link
Copy Markdown
Owner

I fixed the conflict @Abhinav-Bansal751 kindly resolve the requested changes thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Abhinav-Bansal751

Abhinav-Bansal751 commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

Sir,Should i make another commit ?i have deleted "magicc": "^0.2.1", from package.json, made config.json same as earlier.
Also i will commit with yarn.lock file deleted this time as u have mentioned
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga

warengonzaga commented Oct 11, 2024

Copy link
Copy Markdown
Owner

Yes @Abhinav-Bansal751 please made the requested changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Abhinav-Bansal751 added 4 commits October 11, 2024 10:22
@Abhinav-Bansal751
delete yarn file,made config.json as earlier,removed magicc from paka…
c7bcec9 
…ge.json
@Abhinav-Bansal751
delete yarn file,made config.json as earlier,removed magicc from paka…
a194e8e 
…ge.json
@Abhinav-Bansal751
delete yarn file,made config.json as earlier,removed magicc from paka…
b60932c 
…ge.json
@Abhinav-Bansal751
added new script for windows users,setup:windows
1ba482a
warengonzaga
warengonzaga requested changes Oct 11, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another requested changes @Abhinav-Bansal751 kindly take a look.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@warengonzaga warengonzaga mentioned this pull request Oct 11, 2024
write a basic unit test for the command line app #10
Open
@Abhinav-Bansal751
changed Package.json as requested
1efdb9a
warengonzaga
warengonzaga requested changes Oct 11, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @Abhinav-Bansal751 however, I have some requested changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread package.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Abhinav-Bansal751
updated Package.json scripts
d334a21
warengonzaga
warengonzaga approved these changes Oct 11, 2024
View reviewed changes

@warengonzaga warengonzaga left a comment

Copy link
Copy Markdown
Owner

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@warengonzaga
warengonzaga merged commit b6ae7ef into warengonzaga:dev Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warengonzaga warengonzaga warengonzaga approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Abhinav-Bansal751 Abhinav-Bansal751

Labels

feature Feature Request (Issue) hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Abhinav-Bansal751 @warengonzaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.