GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Use `JSValue` instead for `JSPromise`'s closure return types · wfltaylor/JavaScriptKit@5eed2c6

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

Sources/JavaScriptKit/BasicObjects
- JSPromise.swift
Tests/JavaScriptEventLoopTests
- JSPromiseTests.swift

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎Sources/JavaScriptKit/BasicObjects/JSPromise.swift‎`

Copy file name to clipboardExpand all lines: Sources/JavaScriptKit/BasicObjects/JSPromise.swift

+8-8Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public final class JSPromise: JSBridgedClass {`
`86`	`86`
`87`	`87`	/// Schedules the `success` closure to be invoked on successful completion of `self`.
`88`	`88`	`@discardableResult`
`89`		`- public func then(success: @escaping (JSValue) -> some ConvertibleToJSValue) -> JSPromise {`
	`89`	`+ public func then(success: @escaping (JSValue) -> JSValue) -> JSPromise {`
`90`	`90`	`let closure = JSOneshotClosure {`
`91`	`91`	`success($0[0]).jsValue`
`92`	`92`	`}`
`@@ -98,7 +98,7 @@ public final class JSPromise: JSBridgedClass {`
`98`	`98`	`@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)`
`99`	`99`	`@discardableResult`
`100`	`100`	`public func then(`
`101`		`- success: sending @escaping (sending JSValue) async throws -> some ConvertibleToJSValue`
	`101`	`+ success: sending @escaping (sending JSValue) async throws -> JSValue`
`102`	`102`	`) -> JSPromise {`
`103`	`103`	`let closure = JSOneshotClosure.async {`
`104`	`104`	`try await success($0[0]).jsValue`
`@@ -110,8 +110,8 @@ public final class JSPromise: JSBridgedClass {`
`110`	`110`	/// Schedules the `success` closure to be invoked on successful completion of `self`.
`111`	`111`	`@discardableResult`
`112`	`112`	`public func then(`
`113`		`- success: @escaping (sending JSValue) -> some ConvertibleToJSValue,`
`114`		`- failure: @escaping (sending JSValue) -> some ConvertibleToJSValue`
	`113`	`+ success: @escaping (sending JSValue) -> JSValue,`
	`114`	`+ failure: @escaping (sending JSValue) -> JSValue`
`115`	`115`	`) -> JSPromise {`
`116`	`116`	`let successClosure = JSOneshotClosure {`
`117`	`117`	`success($0[0]).jsValue`
`@@ -127,8 +127,8 @@ public final class JSPromise: JSBridgedClass {`
`127`	`127`	`@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)`
`128`	`128`	`@discardableResult`
`129`	`129`	`public func then(`
`130`		`- success: sending @escaping (sending JSValue) async throws -> some ConvertibleToJSValue,`
`131`		`- failure: sending @escaping (sending JSValue) async throws -> some ConvertibleToJSValue`
	`130`	`+ success: sending @escaping (sending JSValue) async throws -> JSValue,`
	`131`	`+ failure: sending @escaping (sending JSValue) async throws -> JSValue`
`132`	`132`	`) -> JSPromise {`
`133`	`133`	`let successClosure = JSOneshotClosure.async {`
`134`	`134`	`try await success($0[0]).jsValue`
`@@ -143,7 +143,7 @@ public final class JSPromise: JSBridgedClass {`
`143`	`143`	/// Schedules the `failure` closure to be invoked on rejected completion of `self`.
`144`	`144`	`@discardableResult`
`145`	`145`	public func `catch`(
`146`		`- failure: @escaping (sending JSValue) -> some ConvertibleToJSValue`
	`146`	`+ failure: @escaping (sending JSValue) -> JSValue`
`147`	`147`	`)`
`148`	`148`	`-> JSPromise`
`149`	`149`	`{`
`@@ -158,7 +158,7 @@ public final class JSPromise: JSBridgedClass {`
`158`	`158`	`@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)`
`159`	`159`	`@discardableResult`
`160`	`160`	public func `catch`(
`161`		`- failure: sending @escaping (sending JSValue) async throws -> some ConvertibleToJSValue`
	`161`	`+ failure: sending @escaping (sending JSValue) async throws -> JSValue`
`162`	`162`	`) -> JSPromise {`
`163`	`163`	`let closure = JSOneshotClosure.async {`
`164`	`164`	`try await failure($0[0]).jsValue`

Collapse file

`‎Tests/JavaScriptEventLoopTests/JSPromiseTests.swift‎`

Copy file name to clipboardExpand all lines: Tests/JavaScriptEventLoopTests/JSPromiseTests.swift

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,14 +9,14 @@ final class JSPromiseTests: XCTestCase {`
`9`	`9`	`p1 = p1.then { value in`
`10`	`10`	`XCTAssertEqual(value, .null)`
`11`	`11`	`continuation.resume()`
`12`		`- return JSValue.number(1.0)`
	`12`	`+ return JSValue.number(1.0).jsValue`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`	`await withCheckedContinuation { continuation in`
`16`	`16`	`p1 = p1.then { value in`
`17`	`17`	`XCTAssertEqual(value, .number(1.0))`
`18`	`18`	`continuation.resume()`
`19`		`- return JSPromise.resolve(JSValue.boolean(true))`
	`19`	`+ return JSPromise.resolve(JSValue.boolean(true)).jsValue`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`	`await withCheckedContinuation { continuation in`
`@@ -48,7 +48,7 @@ final class JSPromiseTests: XCTestCase {`
`48`	`48`	`p2 = p2.then { value in`
`49`	`49`	`XCTAssertEqual(value, .boolean(true))`
`50`	`50`	`continuation.resume()`
`51`		`- return JSPromise.reject(JSValue.number(2.0))`
	`51`	`+ return JSPromise.reject(JSValue.number(2.0)).jsValue`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	`await withCheckedContinuation { continuation in`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.