GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — speed up view, add simd interface to strided view by wolfv · Pull Request #1627 · xtensor-stack/xtensor

Conversation

wolfv commented May 24, 2019

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

wolfv force-pushed the speedyview branch from 0d1e886 to bb7d0e4 Compare

May 24, 2019 18:02

wolfv mentioned this pull request

May 26, 2019

Potential performance issue with reductions (variance, specially) #1622

Closed

wolfv mentioned this pull request

Jun 9, 2019

xtensor lazy evaluation DavisVaughan/rray1#205

Closed

tatatupi commented Jun 10, 2019

Copy link

Copy Markdown

Contributor

Any news on this PR?

It failed on the xtest_extended_xmath.average test.

/home/travis/build/QuantStack/xtensor/test/test_extended_xmath_reducers.cpp:810: Failure
Value of: xt::allclose(av, py_av)
  Actual: false
Expected: true
[  FAILED  ] xtest_extended_xmath.average (0 ms)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohanMabille commented Jun 11, 2019

Copy link

Copy Markdown

Member

Yes we have a vicious bug in release when TBB is enable and all the tests are run. (Running only the failing tests with the same build options makes them magically pass).
We have been quite busy these two last weeks with workshops and conferences, we should have more time to investigate this now.

tatatupi reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wolfv mentioned this pull request

Jul 27, 2019

performance issue with increment_stepper #1695

Open

wolfv mentioned this pull request

Aug 3, 2019

Performance of xt::nanmean xtensor-stack/xtensor-python#201

Open

cemoktra commented Nov 25, 2019

Copy link

Copy Markdown

Contributor

What is the status on this? I just tested it on my machine and the performance gain for calculating the variance is about factor 100 on my machine

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohanMabille commented Nov 25, 2019

Copy link

Copy Markdown

Member

The status has not evolved since June, we still have some weird bug on the CI when TBB is enabled. (Now we also have some conflicts due to the recent refactoring in xtensor).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SoundDev commented Nov 25, 2019

Copy link

Copy Markdown

Contributor

I am also interested in this, we use a lot of strided views.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wolfv added 3 commits

November 27, 2019 11:09


          speed up view, add simd interface to strided view

1cd32ac


          fix up xview for fast iterators

24c01d8


          disable xsimd interface for non-contiguous strided view

6d99e47

JohanMabille force-pushed the speedyview branch 5 times, most recently from c08dcba to 91ed927 Compare

November 28, 2019 23:58


          switch test for layout

3f917ce

JohanMabille force-pushed the speedyview branch from 91ed927 to 63fcbbc Compare

November 29, 2019 00:11

JohanMabille commented Nov 29, 2019

Copy link

Copy Markdown

Member

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohanMabille force-pushed the speedyview branch 5 times, most recently from fc2427a to c4f0e11 Compare

November 29, 2019 09:57

emmenlau commented Nov 29, 2019

Copy link

Copy Markdown

Contributor

Santa may be early this year? Two thumbs up for speedy views!!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohanMabille commented Nov 29, 2019

Copy link

Copy Markdown

Member

Well we still have random issues with TBB (and now OpenMP) :/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohanMabille force-pushed the speedyview branch 2 times, most recently from 25f7699 to 7d42a17 Compare

November 29, 2019 10:50


          Fixed rebase

7d42a17

wolfv merged commit ef28f5a into xtensor-stack:master

Nov 29, 2019

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.