GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge pull request #303 from JohanMabille/pybind11 · xtensor-stack/xtensor-python@c0915c3

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • CMakeLists.txt
  • environment-dev.yml
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎CMakeLists.txt‎

Copy file name to clipboardExpand all lines: CMakeLists.txt
+8-3Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,18 @@ else()
4545
find_package(xtensor ${xtensor_REQUIRED_VERSION} REQUIRED)
4646
message(STATUS "Found xtensor: ${xtensor_INCLUDE_DIRS}/xtensor")
4747
endif()
48-
49-
# Currently no required version for pybind11
48+
49+
# Running find_package(PythonInterp) to retrieve the Python version
50+
# which is not exported by Pybind11's cmake.
51+
# Cf. https://github.com/pybind/pybind11/issues/2268
52+
find_package(PythonInterp ${PythonLibsNew_FIND_VERSION} REQUIRED)
53+
54+
set(pybind11_REQUIRED_VERSION 2.6.1)
5055
if(TARGET pybind11 OR TARGET pybind11::headers)
5156
# pybind11 has a variable that indicates its version already, so use that
5257
message(STATUS "Found pybind11 v${pybind11_VERSION}")
5358
else()
54-
find_package(pybind11 REQUIRED)
59+
find_package(pybind11 ${pybind11_REQUIRED_VERSION} REQUIRED)
5560
message(STATUS "Found pybind11: ${pybind11_INCLUDE_DIRS}/pybind11")
5661
endif()
5762

Collapse file

‎environment-dev.yml‎

Copy file name to clipboardExpand all lines: environment-dev.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ dependencies:
66
- cmake
77
- ninja
88
# Host dependencies
9-
- xtensor=0.24.0
9+
- xtensor>=0.24,<0.25
1010
- numpy
11-
- pybind11=2.4.3
11+
- pybind11>=2.6.1,<3
1212
# Test dependencies
1313
- pytest
1414

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.