GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Edit Task
  • Edit Related Tasks...
  • Create Subtask
  • Edit Parent Tasks
  • Edit Subtasks
  • Merge Duplicates In
  • Close As Duplicate
  • Edit Commits
  • Edit Mocks
  • Mute Notifications
  • Protect as security issue
  • Code-Stewardship-Reviews
  • (Backlog)
  • SpamBlacklist

This view

  • Original page
  • New address

GeezerVison is showing phabricator.wikimedia.org — T224921 Code Stewardship Review: SpamBlacklist

Page MenuHomePhabricator
Log In
Create Task
Maniphest T224921

Code Stewardship Review: SpamBlacklist
Open, MediumPublic
Actions

  • Edit Task
  • Edit Related Tasks...
  • Create Subtask
  • Edit Parent Tasks
  • Edit Subtasks
  • Merge Duplicates In
  • Close As Duplicate
  • Edit Related Objects...
  • Edit Commits
  • Edit Mocks
  • Mute Notifications
  • Protect as security issue
Assigned To
None
Authored By
• Jrbranaa
Jun 3 2019, 6:16 PM2019-06-03 18:16:41 (UTC+0)
Project Tags
  • Code-Stewardship-Reviews (Backlog)
  • SpamBlacklist (Backlog)
Referenced Files
None
Subscribers
Aklapper
Bawolff
Beetstra
Bovlb
Jdforrester-WMF
Johannnes89
• Jrbranaa
View All 9 Subscribers

Description

Intro

The SpamBlacklist extension's presumed Code Steward is actually not the Code Steward. There's been some outstanding production errors that have been occurring for over a year in addition to some CI instability issues.

Number, severity, and age of known and confirmed security issues

TBD

Was it a cause of production outages or incidents? List them.

TBD

Does it have sufficient hardware resources for now and the near future (to take into account expected usage growth)?

n/a

Is it a frequent cause of monitoring alerts that need action, and are they addressed timely and appropriately?

Yes, there have been some ongoing errors in production (see T148639→T64864).

When it was first deployed to Wikimedia production

unknown

Usage statistics based on audience(s) served

TBD

Changes committed in last 1, 3, 6, and 12 months

TBD

Reliance on outdated platforms (e.g. operating systems)

n/a

Number of developers who committed code in the last 1, 3, 6, and 12 months

TBD

Number and age of open patches

TBD

Number and age of open bugs

TBD

Number of known dependencies?

TBD

Is there a replacement/alternative for the feature? Is there a plan for a replacement?

Uknown

Submitter's recommendation (what do you propose be done?)

none

Related Objects

  • Mentions
Mentioned In
T420043: Secure Link Filtering Functionality
T315128: email-blacklist not honored if changing email
T352827: Directory traversal allows single-page whitelisting to override entire spam-blacklist entry
Mentioned Here
T279275: Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them
T251047: Spam blacklist lets edits through
T64864: SpamBlacklist: Fix "PHP Warning: preg_match(): Compilation failed: nothing to repeat" in EmailBlacklist
T148639: SpamBlacklist is escaping/validating patterns incorrectly - "Compilation failed: nothing to repeat at offset 13"

Event Timeline

• Jrbranaa created this task.Jun 3 2019, 6:16 PM2019-06-03 18:16:41 (UTC+0)
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 3 2019, 6:16 PM2019-06-03 18:16:41 (UTC+0)
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex updated the task description. (Show Details)Jun 4 2019, 6:09 PM2019-06-04 18:09:06 (UTC+0)
• Jrbranaa added a subscriber: • marcella.Jun 4 2019, 11:07 PM2019-06-04 23:07:48 (UTC+0)
Comment Actions

Hello @marcella, this extension came up as a Code Stewardship review request, but I've noticed that it is marked as being stewarded by the Editing team on developers/maintainers page. Just checking to see what the actual Code Stewardship status is before I dig any deeper.

Aklapper added a comment.Jun 28 2019, 1:34 PM2019-06-28 13:34:22 (UTC+0)
Comment Actions

@marcella: Could you please elaborate if the WMF Editing Team is responsible for the SpamBlacklist extension? Thanks.

greg edited projects, added: Release-Engineering-Team-TODO (201907); removed: Release-Engineering-Team (Kanban).Jul 1 2019, 9:25 PM2019-07-01 21:25:37 (UTC+0) ·
greg moved this task from INBOX to Ready on the Release-Engineering-Team-TODO (201907) board.Jul 1 2019, 9:27 PM2019-07-01 21:27:02 (UTC+0)
greg triaged this task as Medium priority.Jul 3 2019, 10:29 PM2019-07-03 22:29:29 (UTC+0)
greg edited projects, added: Release-Engineering-Team-TODO; removed: Release-Engineering-Team-TODO (201907).Jul 6 2019, 4:33 AM2019-07-06 04:33:24 (UTC+0)
greg moved this task from Should be empty (use Release-Engineering-Team) to Next on the Release-Engineering-Team-TODO board.Jul 6 2019, 5:25 AM2019-07-06 05:25:58 (UTC+0)
greg added a project: Release-Engineering-Team (Code Health).Jul 6 2019, 5:56 AM2019-07-06 05:56:03 (UTC+0) ·
• marcella added a comment.Jul 18 2019, 2:14 PM2019-07-18 14:14:24 (UTC+0)
Comment Actions
In T224921#5292216, @Aklapper wrote:

@marcella: Could you please elaborate if the WMF Editing Team is responsible for the SpamBlacklist extension? Thanks.

This extension is not currently maintained by the WMF Editing Team. We have no specialized knowledge or skills among the team engineers to support this extension. I'll update the developers/maintainers page to reflect that we are not actively maintaining it.

• Jrbranaa moved this task from Backlog to In Review on the Code-Stewardship-Reviews board.Jul 31 2019, 10:01 PM2019-07-31 22:01:40 (UTC+0)
Bawolff subscribed.Jul 31 2019, 11:46 PM2019-07-31 23:46:07 (UTC+0)
Comment Actions

The form seems a little underfilled out... There was basically one production error which arguably was intentional behaviour (albeit maybe a poor design choice not to suppress it)

Anomie subscribed.Aug 5 2019, 12:55 PM2019-08-05 12:55:43 (UTC+0)
Nikerabbit subscribed.Aug 21 2019, 1:23 PM2019-08-21 13:23:39 (UTC+0)
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM2020-10-16 17:02:05 (UTC+0) ·
Beetstra subscribed.Oct 22 2020, 11:55 AM2020-10-22 11:55:51 (UTC+0)
Krinkle subscribed.Nov 6 2020, 11:39 PM2020-11-06 23:39:28 (UTC+0)
Comment Actions

Still waiting for a code review 1+ year later at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SpamBlacklist/+/505688.

Bovlb subscribed.Apr 5 2021, 2:22 AM2021-04-05 02:22:10 (UTC+0)
Comment Actions
In T224921#5382785, @Bawolff wrote:

There was basically one production error which arguably was intentional behaviour (albeit maybe a poor design choice not to suppress it)

At the Wikidata project, we have been struggling to use this extension as it does not seem to behave as documented. We add URLs to the blacklist and the API confirms that they are blocked, but editors can go right ahead and add them anyway. See T251047 where this was reported a year ago, but we still have no guidance on whether we should even keep attempting to use this anti-vandalism tool.

thcipriani removed a project: Release-Engineering-Team (Code Health).Apr 20 2021, 12:00 AM2021-04-20 00:00:52 (UTC+0) ·
thcipriani removed a project: Release-Engineering-Team-TODO.Apr 20 2021, 12:01 AM2021-04-20 00:01:37 (UTC+0)
Aklapper removed • Jrbranaa as the assignee of this task.Jul 2 2021, 5:16 AM2021-07-02 05:16:13 (UTC+0)
Comment Actions

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Aklapper moved this task from In Review to Backlog on the Code-Stewardship-Reviews board.May 3 2022, 7:39 AM2022-05-03 07:39:15 (UTC+0)
Aklapper removed a subscriber: • marcella.
Comment Actions

For everyone's info, currently no Code-Stewardship-Reviews are taking place as there is no clear path forward and as this is not prioritized work.
(Entirely personal opinion: I also assume lack of decision authority due to WMF not having a CTO currently. However, discussing this is off-topic for this task.)

Peachey88 added a project: SpamBlacklist.May 18 2023, 9:43 AM2023-05-18 09:43:46 (UTC+0)
sbassett mentioned this in T352827: Directory traversal allows single-page whitelisting to override entire spam-blacklist entry.Dec 6 2023, 7:42 PM2023-12-06 19:42:24 (UTC+0)
Krinkle mentioned this in T315128: email-blacklist not honored if changing email.Sep 24 2024, 10:06 PM2024-09-24 22:06:50 (UTC+0)
Jdforrester-WMF subscribed.Sep 24 2024, 10:48 PM2024-09-24 22:48:30 (UTC+0)
Comment Actions

Note that the work on T279275: Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them, if completed, will mean that this extension is undeployed from Wikimedia, un-bundled from MediaWiki, and likely archived (unless someone comes along to support it).

Johannnes89 subscribed.Jan 1 2026, 1:49 PM2026-01-01 13:49:39 (UTC+0)
cscott mentioned this in T420043: Secure Link Filtering Functionality.Mar 13 2026, 6:58 PM2026-03-13 18:58:10 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.