Is there evidence this was not the case before? These are two distinct actions: page move = 1 edit; redirect creation = 1 edit. That's 2 edits in total.

The redirect creation is considered completely separate action even though it happens as a by-product in some sense, but it does much more than that since a new author and creation timestamp is recorded making it a complete new (redirect) page.

No reply from reporter. Closing.

I have created https://www.thetestwiki.org/wiki/T296035 and https://en.wikipedia.org/wiki/User:GeoffreyT2000/T296035 on The Test Wiki and the English Wikipedia respectively to test the difference. Before moving, my edit counts were 94 and 41,894 respectively. After moving, my edit counts increased to 95 and 41,896 respectively. Clearly, moving a page used to increase the user's edit count by 1 (and The Test Wiki still uses an older version of MediaWiki), but now (in MediaWiki 1.38) the user's edit count is increased by 2.

Change 765563 had a related patch set uploaded (by GeoffreyT2000; author: GeoffreyT2000):

[mediawiki/core@master] Increment edit count only if the redirect is suppressed

https://gerrit.wikimedia.org/r/765563

Let's make this a blocker for MW 1.39. If the change gets merged in master, then I will backport it to 1.38.

The idea that something this trivial should block a release is utterly ridiculous.

In T296035#7590148, @GeoffreyT2000 wrote:

I have created https://www.thetestwiki.org/wiki/T296035 and https://en.wikipedia.org/wiki/User:GeoffreyT2000/T296035 on The Test Wiki and the English Wikipedia respectively to test the difference. Before moving, my edit counts were 94 and 41,894 respectively. After moving, my edit counts increased to 95 and 41,896 respectively. Clearly, moving a page used to increase the user's edit count by 1 (and The Test Wiki still uses an older version of MediaWiki), but now (in MediaWiki 1.38) the user's edit count is increased by 2.

So previously there was a bug, and that was fixed, but you want it reverted? Can you explain in more detail why? Your commit's comment justifying the change (claiming that after the fix it will count as two edits, not three) is at odds with your comments here in Phabricator.

In T296035#8072424, @Jdforrester-WMF wrote:

In T296035#7590148, @GeoffreyT2000 wrote:

I have created https://www.thetestwiki.org/wiki/T296035 and https://en.wikipedia.org/wiki/User:GeoffreyT2000/T296035 on The Test Wiki and the English Wikipedia respectively to test the difference. Before moving, my edit counts were 94 and 41,894 respectively. After moving, my edit counts increased to 95 and 41,896 respectively. Clearly, moving a page used to increase the user's edit count by 1 (and The Test Wiki still uses an older version of MediaWiki), but now (in MediaWiki 1.38) the user's edit count is increased by 2.

So previously there was a bug, and that was fixed, but you want it reverted? Can you explain in more detail why? Your commit's comment justifying the change (claiming that after the fix it will count as two edits, not three) is at odds with your comments here in Phabricator.

There has never been a "bug". The behavior prior to the PageUpdater change has always been to increment the edit count by 1 for each move, with no additional increment for the redirect. Now, with PageUpdater being used to create the redirect, PageUpdater will also increment the edit count for the redirect. The correct behavior is to treat the null edit and the redirect as the same move, not as separate edits, when updating the edit count. So, the original change actually introduced a bug, not fixed one.

In T296035#8072525, @GeoffreyT2000 wrote:

In T296035#8072424, @Jdforrester-WMF wrote:

In T296035#7590148, @GeoffreyT2000 wrote:

I have created https://www.thetestwiki.org/wiki/T296035 and https://en.wikipedia.org/wiki/User:GeoffreyT2000/T296035 on The Test Wiki and the English Wikipedia respectively to test the difference. Before moving, my edit counts were 94 and 41,894 respectively. After moving, my edit counts increased to 95 and 41,896 respectively. Clearly, moving a page used to increase the user's edit count by 1 (and The Test Wiki still uses an older version of MediaWiki), but now (in MediaWiki 1.38) the user's edit count is increased by 2.

So previously there was a bug, and that was fixed, but you want it reverted? Can you explain in more detail why? Your commit's comment justifying the change (claiming that after the fix it will count as two edits, not three) is at odds with your comments here in Phabricator.

There has never been a "bug". The behavior prior to the PageUpdater change has always been to increment the edit count by 1 for each move, with no additional increment for the redirect.

That definitely sounds like a bug to me; two entries in RecentChanges but only one edit increment. Clearly, you think otherwise.

Now, with PageUpdater being used to create the redirect, PageUpdater will also increment the edit count for the redirect. The correct behavior is to treat the null edit and the redirect as the same move, not as separate edits, when updating the edit count. So, the original change actually introduced a bug, not fixed one.

Right, so even though you say there's a bug in incrementing by 2 instead of 1, your changes don't fix it, but instead fix a different one, of incrementing by 3 instead of 2?

In T296035#8072781, @Jdforrester-WMF wrote:

In T296035#8072525, @GeoffreyT2000 wrote:

In T296035#8072424, @Jdforrester-WMF wrote:

In T296035#7590148, @GeoffreyT2000 wrote:

I have created https://www.thetestwiki.org/wiki/T296035 and https://en.wikipedia.org/wiki/User:GeoffreyT2000/T296035 on The Test Wiki and the English Wikipedia respectively to test the difference. Before moving, my edit counts were 94 and 41,894 respectively. After moving, my edit counts increased to 95 and 41,896 respectively. Clearly, moving a page used to increase the user's edit count by 1 (and The Test Wiki still uses an older version of MediaWiki), but now (in MediaWiki 1.38) the user's edit count is increased by 2.

So previously there was a bug, and that was fixed, but you want it reverted? Can you explain in more detail why? Your commit's comment justifying the change (claiming that after the fix it will count as two edits, not three) is at odds with your comments here in Phabricator.

There has never been a "bug". The behavior prior to the PageUpdater change has always been to increment the edit count by 1 for each move, with no additional increment for the redirect.

That definitely sounds like a bug to me; two entries in RecentChanges but only one edit increment. Clearly, you think otherwise.

Now, with PageUpdater being used to create the redirect, PageUpdater will also increment the edit count for the redirect. The correct behavior is to treat the null edit and the redirect as the same move, not as separate edits, when updating the edit count. So, the original change actually introduced a bug, not fixed one.

Right, so even though you say there's a bug in incrementing by 2 instead of 1, your changes don't fix it, but instead fix a different one, of incrementing by 3 instead of 2?

Neither the current code nor the proposed new code will increment the edit count by 3 for any move. The current code does two increments for each move leaving a redirect behind, one for the move and another for the redirect. With the proposed new code, the non-PageUpdater increment in MovePage.php will only happen if the redirect is suppressed. If the redirect is left behind, then that increment is redundant, since another increment is already done with PageUpdater creating the redirect.

Change 765563 abandoned by GeoffreyT2000:

[mediawiki/core@master] Increment edit count only if the redirect is suppressed

Reason:

A different patch will be proposed instead.

https://gerrit.wikimedia.org/r/765563

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1099368.