GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Check all project parents for SCM information. by slawekjaranowski · Pull Request #1421 · apache/maven-release

Conversation

@slawekjaranowski

@slawekjaranowski slawekjaranowski commented Nov 18, 2025

Copy link
Copy Markdown
Member

During the project transformation, we need to verify all parent projects.
Otherwise, modules at deeper levels may have an SCM tag added unnecessarily.

fix #1420

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@slawekjaranowski

slawekjaranowski commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

Introduced in:

  • Add "serverId" and "privateKey" SCM parameters #1385
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@slawekjaranowski
slawekjaranowski requested review from cstamas and kwin November 18, 2025 23:22
kwin
kwin approved these changes Nov 19, 2025
View reviewed changes

@kwin kwin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Just minor remarks on comments. Otherwise LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread ...e-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForBranchPhase.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread ...-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@slawekjaranowski
slawekjaranowski force-pushed the gh-1420 branch from d3963ce to 220a17d Compare November 19, 2025 10:13
@slawekjaranowski
Check all project parents for SCM information.
db93204 
During the project transformation, we need to verify all parent projects.
Otherwise, modules at deeper levels may have an SCM tag added unnecessarily.

fix apache#1420
@slawekjaranowski
slawekjaranowski force-pushed the gh-1420 branch from 220a17d to db93204 Compare November 19, 2025 10:24
@slawekjaranowski slawekjaranowski added this to the 3.2.1 milestone Nov 19, 2025
@slawekjaranowski
slawekjaranowski merged commit f0313fc into apache:master Nov 19, 2025
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@slawekjaranowski
slawekjaranowski deleted the gh-1420 branch November 19, 2025 13:57
@github-actions

github-actions Bot commented Nov 19, 2025

Copy link
Copy Markdown

@slawekjaranowski Please assign appropriate label to PR according to the type of change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned slawekjaranowski Nov 19, 2025
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwin kwin kwin approved these changes
@cstamas cstamas Awaiting requested review from cstamas

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@slawekjaranowski slawekjaranowski

Labels

bug Something isn't working

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

scm/tag is unnecessarily added in nested submodules (depth > 1)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@slawekjaranowski @kwin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.