GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Resolve todo that led to pointless asserts by elharo · Pull Request #1442 · apache/maven-release

Conversation

@elharo

@elharo elharo commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

comparePomFiles always returned true. If it fails it throws an IOException.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
elharo added 2 commits November 28, 2025 13:47
@elharo
Resolve todo that led to pointless asserts
772aaa3
@elharo
Remove unused method
78315a7
@elharo
elharo marked this pull request as ready for review November 28, 2025 20:00
@elharo
elharo requested a review from slawekjaranowski November 28, 2025 20:00
slawekjaranowski
slawekjaranowski approved these changes Nov 28, 2025
View reviewed changes
@elharo
elharo merged commit 7e861f0 into master Nov 28, 2025
30 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@elharo
elharo deleted the todo branch November 28, 2025 21:55
@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown

@elharo Please assign appropriate label to PR according to the type of change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot assigned elharo Nov 28, 2025
@github-actions github-actions Bot added this to the 3.3.0 milestone Nov 28, 2025
@elharo elharo added java Pull requests that update Java code maintenance labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@elharo elharo

Labels

java Pull requests that update Java code maintenance

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@elharo @slawekjaranowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.