GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Never add a vendored smmap directory to sys.path by EliahKagan · Pull Request #102 · gitpython-developers/gitdb

This repository was archived by the owner on Jul 26, 2026. It is now read-only.

Conversation

@EliahKagan

@EliahKagan EliahKagan commented Oct 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This removes the logic that appended the git submodule directory for smmap to sys.path under most circumstances when the version of gitdb was not from PyPI. Now gitdb does not modify sys.path.

See GitPython#1717 and GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.

Please note that this does not make any documentation changes (and the changes in #103 are not related to this).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EliahKagan
Never add a vendored smmap directory to sys.path
965d2d3 
This removes the logic that appended the git submodule directory
for smmap to sys.path under most circumstances when the version
of gitdb was not from PyPI. Now gitdb does not modify sys.path.

See gitpython-developers/GitPython#1717
and gitpython-developers/GitPython#1720 for
context. This change is roughly equivalent to the change to
GitPython, though as noted the behavior being eliminated is subtly
different here and there.
This was referenced Oct 20, 2023
We appear to import the submodule version of gitdb (but never do) gitpython-developers/GitPython#1717
Closed
Never modify sys.path gitpython-developers/GitPython#1720
Merged
Revise and update the readme #103
Merged
Byron
Byron approved these changes Oct 20, 2023
View reviewed changes

@Byron Byron left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this 🙏!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
EliahKagan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Byron
Byron merged commit 9302789 into gitpython-developers:master Oct 20, 2023
@EliahKagan
EliahKagan deleted the nopathmod branch October 20, 2023 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Byron Byron Byron approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EliahKagan @Byron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.