GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Place `module-info` in the root of the jar. by cpovirk · Pull Request #809 · jspecify/jspecify Conversation
Collaborator
...instead of in a multi-release directory. Fixes #484
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
...instead of in a multi-release directory. Fixes #484
netdpb
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good to me, although I'm no expert.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
copybara-service Bot
pushed a commit
to google/guava
that referenced
this pull request
...instead of in a multi-release directory. We recently [did this for JSpecify](jspecify/jspecify#809) (released in [1.0.1](https://github.com/jspecify/jspecify/releases/tag/v1.0.1)), primarily to avoid [some problems related to `META-INF/versions/9/OSGI-INF/MANIFEST.MF`](jspecify/jspecify#484 (comment)). Granted, the _main_ domain of those problems (but [not only domain](google/error-prone#4971)!) was Android, and `guava-android` isn't ([yet](#7813)?) a module (since we don't include a `module-info.java` file there, even though plenty of module-related configuration is in place), only an "automatic module." We're also told that [JUnit 5 has done this for years](jspecify/jspecify#484 (comment)) while also supporting Java 8, so that is yet more reason to expect it to be safe. (This CL is an incremental bonus step in #7094.) RELNOTES=The Guava `module-info.class` is now present at the root of the jar instead of under [a multi-release root](https://openjdk.org/jeps/238). This prevents the jar from containing a file at `META-INF/versions/9/OSGI-INF/MANIFEST.MF`, which occasionally causes [trouble for some users](jspecify/jspecify#484 (comment)). PiperOrigin-RevId: 959773233
copybara-service Bot
pushed a commit
to google/guava
that referenced
this pull request
...instead of in a multi-release directory. We recently [did this for JSpecify](jspecify/jspecify#809) (released in [1.0.1](https://github.com/jspecify/jspecify/releases/tag/v1.0.1)), primarily to avoid [some problems related to `META-INF/versions/9/OSGI-INF/MANIFEST.MF`](jspecify/jspecify#484 (comment)). Granted, the _main_ domain of those problems (but [not only domain](google/error-prone#4971)!) was Android, and `guava-android` isn't ([yet](#7813)?) a module (since we don't include a `module-info.java` file there, even though plenty of module-related configuration is in place), only an "automatic module." We're also told that [JUnit 5 has done this for years](jspecify/jspecify#484 (comment)) while also supporting Java 8, so that is yet more reason to expect it to be safe. (This CL is an incremental bonus step in #7094.) RELNOTES=The Guava `module-info.class` is now present at the root of the jar instead of under [a multi-release root](https://openjdk.org/jeps/238). This prevents the jar from containing a file at `META-INF/versions/9/OSGI-INF/MANIFEST.MF`, which occasionally causes [trouble for some users](jspecify/jspecify#484 (comment)). PiperOrigin-RevId: 960605760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Move module-info back to the main root?Uh oh!
There was an error while loading. Please reload this page. 2 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |
