GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Exclude completions of binding pattern variable initializers by zardoy · Pull Request #52723 · microsoft/TypeScript

Conversation

@zardoy

@zardoy Vitaly (zardoy) commented Feb 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #53049

const {a1} = a/* should not complete a1 */

Real world case:

let pageToReturn

const { data: pageData } = await octokit.repos.listTags({
    page: page /* pageData is suggested first */
})

Some kind of follow up for #42087

Decided to build on top of #52690 (so there is no conflicts if gets merged)

For now will wait until that PR is merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
svipas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 11, 2023
@zardoy Vitaly (zardoy) mentioned this pull request Mar 1, 2023
Exclude completions of binding pattern variable initializers #53049
Closed
Vitaly (zardoy) added 2 commits April 20, 2023 15:45
@zardoy
exclude completions of binding pattern variable initializers
d62bcc5
@zardoy
add basic tests!
c4d73a0
@zardoy
Vitaly (zardoy) force-pushed the no-self-completions-from-binding-pattern branch from af52d4c to c4d73a0 Compare April 20, 2023 12:50
@zardoy
Vitaly (zardoy) marked this pull request as ready for review April 20, 2023 12:50
@sandersn
Merge branch 'main' into no-self-completions-from-binding-pattern
7d1de09
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Apr 2, 2025
View reviewed changes
@sandersn

Nathan Shively-Sanders (sandersn) commented Apr 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

New changes require approval from someone other than sandersn because they were the last pusher.

well this is annoying
zardoy reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakebailey
Jake Bailey (jakebailey) approved these changes Apr 2, 2025
View reviewed changes
@sandersn
Nathan Shively-Sanders (sandersn) merged commit ba663f6 into microsoft:main Apr 2, 2025
@zardoy

Vitaly (zardoy) commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Thank you! You are the best!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exclude completions of binding pattern variable initializers

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zardoy @sandersn @jakebailey @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.