GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix errors on type assertions in erasableSyntaxOnly by DanielRosenwasser · Pull Request #61452 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Mar 19, 2025

Copy link
Copy Markdown
Member

Brings in fixes/simplifications mentioned in #61244 (comment) and #61320 (comment).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Daniel Rosenwasser (DanielRosenwasser) added 3 commits March 19, 2025 21:49
@DanielRosenwasser
Add test case.
0f255e0
@DanielRosenwasser
Switch span reporting to avoid bounds violation.
c230539
@DanielRosenwasser
Accepted baselines.
0bdf914
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested a review from Jake Bailey (jakebailey) March 19, 2025 21:56
@github-project-automation github-project-automation Bot added this to PR Backlog Mar 19, 2025
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Mar 19, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser) Mar 19, 2025
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 19, 2025
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) changed the title Error on assertion fix Fix errors on type assertions in erasableSyntaxOnly Mar 19, 2025
jakebailey
Jake Bailey (jakebailey) approved these changes Mar 19, 2025
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Mar 19, 2025
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick to release-5.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.8
typescript-bot reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.8 ✅ Started ✅ Results
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Mar 19, 2025
🤖 Pick PR #61452 (Fix errors on type assertions in er...) into release-5.8 #61453
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Hey, Daniel Rosenwasser (@DanielRosenwasser)! I've created #61453 for you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Mar 19, 2025
@typescript-bot @DanielRosenwasser
🤖 Pick PR #61452 (Fix errors on type assertions in er...) into releas…
92eedcb 
…e-5.8 (#61453)

Co-authored-by: Daniel Rosenwasser <[email protected]>
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 4dc677b into main Mar 19, 2025
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the errorOnAssertionFix branch March 19, 2025 23:25
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Mar 19, 2025
@sandersn Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025
@jakebailey Jake Bailey (jakebailey) mentioned this pull request Jun 5, 2025
feat(911): erasableSyntaxOnly not supported microsoft/typescript-go#1068
Merged
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) added this to the TypeScript 5.8.3 milestone Jul 8, 2025
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Jan 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 5.8.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DanielRosenwasser @typescript-bot @jakebailey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.