GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — fix(core): show flaky-task count in run summary by FrozenPandaz · Pull Request #35491 · nrwl/nx Conversation
|
flakyTasks.length |
Body rows |
|---|---|
| 1–5 | all task names |
| 6 | all 6 task names (no collapse — a single "1 more..." would be sillier than just printing the row) |
| 7 | 5 task names + 2 more... |
| 8 | 5 task names + 3 more... |
| N (N≥7) | 5 task names + ${N-5} more... |
Applied symmetrically in both life-cycle files.
No existing unit test covers printFlakyTasksMessage()'s formatted output (the surrounding life cycles don't have a *.spec.ts). Adding one would require mocking the task-history daemon channel and life-cycle hooks — out of scope for a small formatting tweak. The change is small enough to verify by inspection of the diff.
(reported internally; no public issue)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
When more than one flaky task is detected, the summary header rendered 'Nx detected flaky tasks' (two spaces, no number) because the plural branch of the ternary in printFlakyTasksMessage only contained the literal ' flaky tasks' string with a leading space and no count interpolation. Render the count for the plural case while preserving the singular 'Nx detected a flaky task' wording. Same fix applied to both the current and legacy life-cycle handlers.
There was an error while loading. Please reload this page.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
View your CI Pipeline Execution ↗ for commit 341d035
☁️ Nx Cloud last updated this comment at |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe limit this to the first ~3-5 of them and add a row for "and # more" or similar? The original complaint was stemming from the gradle tasks being detected as flaky and filling up the terminal viewport imho
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Done — capped at 5 with a N more... collapse row when there are more than 6 flaky tasks. 341d035
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Cap the printed list at 5 entries with a "N more..." collapse row when there are more than 6 flaky tasks. The title still shows the true total.
There was an error while loading. Please reload this page.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.