GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — 3.4 release blog by sosukesuzuki · Pull Request #16851 · prettier/prettier

Conversation

sosukesuzuki commented Nov 24, 2024

Copy link

Copy Markdown

Member

Description

#16850

Checklist

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
(If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot commented Nov 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Size Change: 0 B

Total Size: 7.86 MB

ℹ️ View Unchanged

Filename	Size
`./dist/bin`	4.1 kB
`./dist/bin/prettier.cjs`	2.24 kB
`./dist/doc.d.ts`	7.42 kB
`./dist/doc.js`	53.1 kB
`./dist/doc.mjs`	49.6 kB
`./dist/index.cjs`	36.8 kB
`./dist/index.d.ts`	26.8 kB
`./dist/index.mjs`	738 kB
`./dist/internal`	4.1 kB
`./dist/internal/cli.mjs`	125 kB
`./dist/LICENSE`	206 kB
`./dist/package.json`	6.3 kB
`./dist/plugins`	4.1 kB
`./dist/plugins/acorn.d.ts`	109 B
`./dist/plugins/acorn.js`	152 kB
`./dist/plugins/acorn.mjs`	152 kB
`./dist/plugins/angular.d.ts`	177 B
`./dist/plugins/angular.js`	85.8 kB
`./dist/plugins/angular.mjs`	85.1 kB
`./dist/plugins/babel.d.ts`	419 B
`./dist/plugins/babel.js`	314 kB
`./dist/plugins/babel.mjs`	314 kB
`./dist/plugins/estree.d.ts`	11 B
`./dist/plugins/estree.js`	201 kB
`./dist/plugins/estree.mjs`	200 kB
`./dist/plugins/flow.d.ts`	90 B
`./dist/plugins/flow.js`	679 kB
`./dist/plugins/flow.mjs`	679 kB
`./dist/plugins/glimmer.d.ts`	93 B
`./dist/plugins/glimmer.js`	137 kB
`./dist/plugins/glimmer.mjs`	137 kB
`./dist/plugins/graphql.d.ts`	93 B
`./dist/plugins/graphql.js`	43.6 kB
`./dist/plugins/graphql.mjs`	43 kB
`./dist/plugins/html.d.ts`	139 B
`./dist/plugins/html.js`	151 kB
`./dist/plugins/html.mjs`	151 kB
`./dist/plugins/markdown.d.ts`	127 B
`./dist/plugins/markdown.js`	149 kB
`./dist/plugins/markdown.mjs`	148 kB
`./dist/plugins/meriyah.d.ts`	93 B
`./dist/plugins/meriyah.js`	131 kB
`./dist/plugins/meriyah.mjs`	131 kB
`./dist/plugins/postcss.d.ts`	121 B
`./dist/plugins/postcss.js`	153 kB
`./dist/plugins/postcss.mjs`	153 kB
`./dist/plugins/typescript.d.ts`	96 B
`./dist/plugins/typescript.js`	896 kB
`./dist/plugins/typescript.mjs`	895 kB
`./dist/plugins/yaml.d.ts`	90 B
`./dist/plugins/yaml.js`	122 kB
`./dist/plugins/yaml.mjs`	122 kB
`./dist/README.md`	4.03 kB
`./dist/standalone.d.ts`	1.37 kB
`./dist/standalone.js`	82.1 kB
`./dist/standalone.mjs`	81.8 kB

_{compressed-size-action}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sosukesuzuki mentioned this pull request

Nov 24, 2024

Release 3.4 #16850

Closed

11 tasks done

sosukesuzuki self-assigned this

Nov 24, 2024

sosukesuzuki requested review from fisker and kachkaev

November 24, 2024 03:49

kachkaev reviewed

Nov 24, 2024

View reviewed changes

kachkaev left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left a couple of small suggestions.

Blog post preview:
https://deploy-preview-16851--prettier.netlify.app/blog/2024/11/25/3.4.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

changelog_unreleased/blog-post-intro.md Outdated

		---
		author: "Sosuke Suzuki (@sosukesuzuki)"
		authorURL: "https://github.com/sosukesuzuki"
		title: "Prettier 3.4: Fixes a lot of bugs"

kachkaev Nov 24, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	title: "Prettier 3.4: Fixes a lot of bugs"
	title: "Prettier 3.4: A lot of bug fixes"

Optional: I could not find a blog post title starting with a verb, but there was https://prettier.io/blog/2019/06/06/1.18.0 for example

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

website/blog/2024-11-24-3.4.0.md Outdated

		// Input
		const string = `${[[1, 2], [3, 4]]}`

		// Prettier 3.2

kachkaev Nov 24, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be

Suggested change

	// Prettier 3.2
	// Prettier 3.3

here and below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

website/blog/2024-11-24-3.4.0.md Outdated

		}
		```

		#### Fixed wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker))

kachkaev Nov 24, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	#### Fixed wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker))
	#### Fix wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

website/blog/2024-11-24-3.4.0.md Outdated


		### Markdown

		#### Removed excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik))

kachkaev Nov 24, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	#### Removed excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik))
	#### Remove excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sosukesuzuki requested a review from kachkaev

November 25, 2024 12:41

fisker commented Nov 25, 2024

Copy link

Copy Markdown

Member

@sosukesuzuki Please wait for me to fix #16860

sosukesuzuki and kachkaev reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fisker approved these changes

Nov 25, 2024

View reviewed changes

kachkaev approved these changes

Nov 25, 2024

View reviewed changes

kachkaev reviewed

Nov 25, 2024

View reviewed changes

Comment thread

website/blog/2024-11-25-3.4.0.md

kachkaev Nov 25, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. We’ll need to change the date if we don’t manage to release 3.4 by the end of today AoE

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sosukesuzuki reacted with thumbs up emoji

All reactions

👍 1 reaction

sosukesuzuki force-pushed the 3.4-blog-post branch from 93705f9 to aa4eb9f Compare

November 26, 2024 04:44

Sosuke Suzuki and others added 7 commits

November 26, 2024 13:55


          Add new blog post

40880c7

Fix

64efb93

Fix

7a4046a


          Fix typo

79c973a


          Fix and regenerate

3d820f0


          Rebase and regenerate

46bc59c


          Regenerate

24ec764

sosukesuzuki force-pushed the 3.4-blog-post branch from aa4eb9f to 24ec764 Compare

November 26, 2024 04:55

sosukesuzuki merged commit 3542f13 into main

Nov 26, 2024

sosukesuzuki deleted the 3.4-blog-post branch

November 26, 2024 05:02

Reviewers

kachkaev

kachkaev approved these changes

fisker

fisker approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

sosukesuzuki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sosukesuzuki commented Nov 24, 2024

Description

Checklist

Uh oh!

github-actions Bot commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kachkaev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kachkaev Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

kachkaev Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

kachkaev Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

kachkaev Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

fisker commented Nov 25, 2024

Uh oh!

kachkaev Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Nov 24, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

kachkaev left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.