GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove Python2 crumbs by a-detiste · Pull Request #12367 · twisted/twisted

Conversation

@a-detiste

@a-detiste a-detiste commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

This is just a little cleanup.

The outdated docs might be confusing to newcomers who didn't got to live through the great Py2 -> 3 transition.

Greetings

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@a-detiste
remove Python2 crumbs
c5b3254
@codspeed

codspeed Bot commented Nov 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #12367 will degrade performances by 3.02%

Comparing a-detiste:trunk (3624f4f) with trunk (a6c0e2d)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark trunk a-detiste:trunk Change
⚡ test_deferred_await_unfired 370.6 µs 361 µs +2.66%
❌ test_tcp_throughput 5.1 ms 5.3 ms -3.02%
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adiroiban
Add release notes fragment.
3624f4f
adiroiban
adiroiban approved these changes Nov 18, 2024
View reviewed changes

@adiroiban adiroiban left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clenaup. It looks good.

I have added a newsfragment file to help with generating the future release notes.

I think that this is a small cleanup and we don't need to add more info for the release notes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/twisted/words/xish/xpathparser.py

exec(
r'''
from __future__ import print_function

@adiroiban adiroiban Nov 18, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this comment at the top of the file

# DO NOT EDIT xpathparser.py!

... I guess that this is ok... we don't need to re-run Yapps for this cleanup

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
a-detiste reacted with eyes emoji
All reactions
  • 👀 1 reaction

@a-detiste a-detiste Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine if the two copies are updated in sync.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@a-detiste a-detiste Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for release notes for this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adiroiban adiroiban changed the title remove Python2 crumbs Remove Python2 crumbs Nov 21, 2024
@adiroiban
adiroiban merged commit 7ac990f into twisted:trunk Nov 21, 2024
@adiroiban

adiroiban commented Nov 21, 2024

Copy link
Copy Markdown
Member

I have merged this as this is mostly a cleanup.

Thanks Alexandre for your help.

@itamarst the performance tests are quite flaky

For now I have just merged this PR by ignoring their results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adiroiban adiroiban adiroiban approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@a-detiste @adiroiban
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.