GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(resolver): support UTF-8 BOM in tsconfig files by stormslowly · Pull Request #16518 · web-infra-dev/rspack

Conversation

@stormslowly

@stormslowly stormslowly commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

resolve.tsConfig rejects tsconfig files with a UTF-8 BOM with expected value at line 1 column 1, while TypeScript accepts them. This addresses the BOM portion of #16495.

Changes

Skip one leading BOM before stripping JSONC comments and parsing the config. Add integration coverage for BOM-prefixed root, extended, and referenced configs, including JSONC syntax and an otherwise empty config.

Validated on Linux with a rebuilt development binding:

  • The new BOM case fails before the fix and passes afterward in both config test modes.
  • pnpm --dir tests/rspack-test run test -t "configCases/resolve" — 80 passed.
  • Resolver Clippy with all targets and features, Rust formatting, JavaScript checks, and config type checks passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stormslowly
fix(resolver): support UTF-8 BOM in tsconfig files
0d9e7eb
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 0d9e7eb to fix(hmr): complete new entry chunk dependencies (#15955) by Fy

🙈 Size remains the same at 68.57MB
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 541.5 KB 0 0
react-10k 5.4 MB 1.3 MB 0 0
react-1k 827.5 KB 225.2 KB 0 0
react-5k 2.6 MB 670.6 KB 0 0
ui-components 4.7 MB 1.4 MB 0 0

Generated by Rsdoctor GitHub Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codspeed

codspeed Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 47 skipped benchmarks1

Comparing codex/issue_16495_bom (0d9e7eb) with main (8d4b11b)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stormslowly
stormslowly requested a review from LingyuCoder November 9, 2026 03:30
LingyuCoder
LingyuCoder approved these changes Nov 9, 2026
View reviewed changes
@stormslowly
stormslowly merged commit d999646 into main Nov 9, 2026
93 of 98 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@stormslowly
stormslowly deleted the codex/issue_16495_bom branch November 9, 2026 08:16
@LingyuCoder LingyuCoder mentioned this pull request Nov 10, 2026
[Bug]: resolve.tsConfig fails on a tsconfig.json with a UTF-8 BOM and uses the wrong entry of an extends array #16493
Closed
@stormslowly stormslowly mentioned this pull request Nov 10, 2026
fix(resolver): respect tsconfig extends array precedence #16554
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@stormslowly @LingyuCoder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.