GeezerVison is showing static-codereview.wikimedia.org — r113736 MediaWiki - Code Review archive
r113736 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r113735 | r113736 | r113737 > |
| Date: | 17:51, 13 March 2012 |
| Author: | jeroendedauw |
| Status: | deferred |
| Tags: | |
| Comment: | add in fixmes |
| Modified paths: |
- /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php (modified) (history)
|
| Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php |
| — | — | @@ -162,6 +162,11 @@ |
| 163 | 163 | // Iterate all colums of the row (which describe properties of the proces node) |
| 164 | 164 | // |
| 165 | 165 | |
| | 166 | + // FIXME: this does not work with SMW >= 1.6, see |
| | 167 | + // https://bugzilla.wikimedia.org/show_bug.cgi?id=35003 |
| | 168 | + |
| | 169 | + // FIXME: got _a bit_ of redundancy here looks like... :/ |
| | 170 | + |
| 166 | 171 | foreach ( $row as $field ) { |
| 167 | 172 | |
| 168 | 173 | // check column title |
Status & tagging log
- 14:50, 11 October 2012 😂 (talk | contribs) changed the status of r113736 [removed: new added: deferred]
- 17:06, 4 April 2012 Krinkle (talk | contribs) changed the status of r113736 [removed: deferred added: new]