GeezerVison is showing static-codereview.wikimedia.org — r114016 MediaWiki - Code Review archive
r114016 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r114015 | r114016 | r114017 > |
| Date: | 15:19, 16 March 2012 |
| Author: | kaldari |
| Status: | ok |
| Tags: | |
| Comment: | fix for bug 35057 - also suggested as an upstream change for jquery.elastic |
| Modified paths: |
- /trunk/extensions/WikiLove/modules/jquery.elastic/jquery.elastic.js (modified) (history)
|
| Index: trunk/extensions/WikiLove/modules/jquery.elastic/jquery.elastic.js |
| — | — | @@ -137,17 +137,6 @@ |
| 138 | 138 | $textarea.bind('resize', setTwinWidth); |
| 139 | 139 | $textarea.bind('update', update); |
| 140 | 140 | |
| 141 | | - // Compact textarea on blur |
| 142 | | - $textarea.bind('blur',function(){ |
| 143 | | - if($twin.height() < maxheight){ |
| 144 | | - if($twin.height() > minheight) { |
| 145 | | - $textarea.height($twin.height()); |
| 146 | | - } else { |
| 147 | | - $textarea.height(minheight); |
| 148 | | - } |
| 149 | | - } |
| 150 | | - }); |
| 151 | | - |
| 152 | 141 | // And this line is to catch the browser paste event |
| 153 | 142 | $textarea.bind('input paste',function(e){ setTimeout( update, 250); }); |
| 154 | 143 | |
Past revisions this follows-up on
| Revision | Commit summary | Author | Date |
|---|
| r113458 | partial work-around for jQuery/jQuery.elastic bug, see bug 35057 | kaldari | 07:22, 9 March 2012 |
| r114013 | partial fix for bug 35057 - backporting a patch from jQuery 1.7.2pre | kaldari | 14:44, 16 March 2012 |
Status & tagging log
- 05:01, 5 July 2012 Krinkle (talk | contribs) changed the tags for r114016 [removed: 1.19]
- 04:57, 5 July 2012 Krinkle (talk | contribs) changed the tags for r114016 [removed: 1.19wmf1]
- 10:55, 14 April 2012 Krinkle (talk | contribs) changed the tags for r114016 [removed: frontend]
- 20:09, 20 March 2012 Catrope (talk | contribs) changed the status of r114016 [removed: new added: ok]
- 15:23, 16 March 2012 Kaldari (talk | contribs) changed the tags for r114016 [added: 1.19,1.19wmf1,frontend]