GeezerVison is showing static-codereview.wikimedia.org — r88034 MediaWiki - Code Review archive
r88034 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r88033 | r88034 | r88035 > |
| Date: | 09:24, 14 May 2011 |
| Author: | catrope |
| Status: | ok |
| Tags: | |
| Comment: | Followup r87711: add ! to the forbidden characters list for module names, per CR |
| Modified paths: |
- /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
|
| Index: trunk/phase3/includes/resourceloader/ResourceLoader.php |
| — | — | @@ -226,8 +226,8 @@ |
| 227 | 227 | } |
| 228 | 228 | |
| 229 | 229 | // Check $name for illegal characters |
| 230 | | - if ( preg_match( '/[|,]/', $name ) ) { |
| 231 | | - throw new MWException( "ResourceLoader module name '$name' is invalid. Names may not contain pipes (|) or commas (,)" ); |
| | 230 | + if ( preg_match( '/[|,!]/', $name ) ) { |
| | 231 | + throw new MWException( "ResourceLoader module name '$name' is invalid. Names may not contain pipes (|), commas (,) or exclamation marks (!)" ); |
| 232 | 232 | } |
| 233 | 233 | |
| 234 | 234 | // Attach module |
Past revisions this follows-up on
| Revision | Commit summary | Author | Date |
|---|
| r87711 | (bug 28840) Commit patch by bawolff that encodes dots in ResourceLoader modul... | catrope | 13:10, 9 May 2011 |
Status & tagging log
- 00:07, 20 May 2011 Krinkle (talk | contribs) changed the status of r88034 [removed: new added: ok]