GeezerVison is showing static-codereview.wikimedia.org — r91876 MediaWiki - Code Review archive
r91876 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r91875 | r91876 | r91877 > |
| Date: | 12:26, 11 July 2011 |
| Author: | nikerabbit |
| Status: | deferred |
| Tags: | |
| Comment: | Google suggestions should obey the group source language |
| Modified paths: |
- /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)
|
| Index: trunk/extensions/Translate/utils/TranslationHelpers.php |
| — | — | @@ -384,7 +384,8 @@ |
| 385 | 385 | return null; |
| 386 | 386 | } |
| 387 | 387 | |
| 388 | | - $options = self::makeGoogleQueryParams( $definition, "en|$code", $config ); |
| | 388 | + $source = $this->group->getSourceLanguage(); |
| | 389 | + $options = self::makeGoogleQueryParams( $definition, "$source|$code", $config ); |
| 389 | 390 | $json = Http::post( $config['url'], $options ); |
| 390 | 391 | $response = FormatJson::decode( $json ); |
| 391 | 392 | |
Status & tagging log
- 19:52, 12 July 2011 Reedy (talk | contribs) changed the status of r91876 [removed: new added: deferred]