GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Create missing `pypyX.Y` symlinks by mayeut · Pull Request #347 · actions/setup-python

Conversation

@mayeut

@mayeut mayeut commented Mar 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Description:
Create missing pypyX.Y symlinks:
pypyX.Y.exe executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
pypy2.7 symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

Related issue:
relates to #346

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mayeut

mayeut commented Mar 5, 2022

Copy link
Copy Markdown
Contributor Author

Before the PR, tests are failing for Windows only (3.Y tests there) when trying to use pypyX.Y: https://github.com/mayeut/packaging/actions/runs/1937384250

After the PR, tests are passing:
https://github.com/mayeut/packaging/actions/runs/1938654790
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 5, 2022
Use pypyX.Y for PyPy python-version input #349
Merged
Use pypyX.Y for PyPy python-version input #346
Closed
@mayeut
mayeut marked this pull request as draft April 2, 2022 12:35
@mayeut

mayeut commented Apr 2, 2022

Copy link
Copy Markdown
Contributor Author

let's go back to draft until PyPy 7.3.9 rollout is complete on GHA hosted runners.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mayeut
mayeut force-pushed the install-pypyX.Y-symlinks branch from e621a16 to 156f48c Compare April 2, 2022 12:36
@mayeut
Create missing pypyX.Y symlinks
8d0fdb2 
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
`pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

relates to actions#346
@mayeut
mayeut force-pushed the install-pypyX.Y-symlinks branch from 156f48c to 8d0fdb2 Compare April 9, 2022 09:26
@mayeut

mayeut commented Apr 9, 2022

Copy link
Copy Markdown
Contributor Author

PyPy 7.3.9 rollout is now complete on GHA hosted runners.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mayeut
mayeut marked this pull request as ready for review April 9, 2022 09:40
@mayeut
mayeut requested a review from a team April 9, 2022 09:40
dmitry-shibanov
dmitry-shibanov approved these changes Apr 11, 2022
View reviewed changes
@mayeut

mayeut commented Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

@marko-zivic-93, @dmitry-shibanov,

anything else I need to do to get this moving forward ? This PR is a pre-requisite for #346 & #349.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsafonkin
vsafonkin approved these changes Apr 28, 2022
View reviewed changes
marko-zivic-93
marko-zivic-93 approved these changes Apr 28, 2022
View reviewed changes
brcrista
brcrista approved these changes Apr 28, 2022
View reviewed changes
@brcrista
brcrista merged commit 1ce3088 into actions:main Apr 28, 2022
@mayeut
mayeut deleted the install-pypyX.Y-symlinks branch April 28, 2022 15:57
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@mayeut
Create missing pypyX.Y symlinks (actions#347)
b054e5d 
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
`pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

relates to actions#346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@vsafonkin vsafonkin vsafonkin approved these changes
@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes
@brcrista brcrista brcrista approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mayeut @vsafonkin @dmitry-shibanov @brcrista @marko-zivic-93
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.