GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Made env.var pythonLocation consistent for Python and PyPy by IvanZosimov · Pull Request #418 · actions/setup-python

Conversation

@IvanZosimov

@IvanZosimov IvanZosimov commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Description:
Environment variable pythonLocation was inconsistent for Python and PyPy. The behaviour of this env. variable was made consistent for both Python and PyPy and a few words about pythonLocation env. variable were added to the documentation.

Related issue:
#60
#78

This is a breaking change, some of our customers may rely on the previous behaviour

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
IvanZosimov added 5 commits May 31, 2022 16:44
IvanZosimov
Change find-pypy.ts to redefine pythonLocaction environment variable
22678cd
IvanZosimov
Change README.md in order to add sentence about pythonLocation envvar
0d36a4d
IvanZosimov
Change sentence about pythonLocation envvar in README.md
baba4c5
IvanZosimov
Rephrase the definition of pythonLocation env.var
1bd000c
IvanZosimov
Merge branch 'main' into python-location-envvar
c6e58c5
@IvanZosimov
IvanZosimov requested review from a team, dmitry-shibanov, dsame, e-korolevskii, marko-zivic-93 and panticmilos June 7, 2022 08:05
marko-zivic-93
marko-zivic-93 approved these changes Jun 7, 2022
View reviewed changes
panticmilos
panticmilos approved these changes Jun 7, 2022
View reviewed changes
vsafonkin
vsafonkin approved these changes Jun 7, 2022
View reviewed changes
@IvanZosimov IvanZosimov mentioned this pull request Jun 7, 2022
Made env.var pythonLocation consistent for Python and PyPy akv-platform/setup-python#3
Closed
dmitry-shibanov
dmitry-shibanov approved these changes Jun 7, 2022
View reviewed changes
@vsafonkin
vsafonkin merged commit f72db17 into actions:main Jun 8, 2022
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@IvanZosimov
Made env.var pythonLocation consistent for Python and PyPy (actions#418)
3a28c88 
* Change find-pypy.ts to redefine pythonLocaction environment variable

* Change README.md in order to add sentence about pythonLocation envvar

* Change sentence about pythonLocation envvar in README.md

* Rephrase the definition of pythonLocation env.var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsame dsame Awaiting requested review from dsame
@e-korolevskii e-korolevskii Awaiting requested review from e-korolevskii
4 more reviewers
@vsafonkin vsafonkin vsafonkin approved these changes
@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
@panticmilos panticmilos panticmilos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@IvanZosimov @vsafonkin @dmitry-shibanov @marko-zivic-93 @panticmilos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.