Description

alex

opened on Oct 9, 2022

Issue body actions

Description:

      - name: Setup python
        uses: actions/[email protected]
        with:
          python-version: "pypy-3.8-nightly"
          architecture: "x86"

Action version:

4.2.0

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:

pypy-3.8-nightly, pypy-3.9-nightly

Repro steps:

Use the action specified above. Look at the output and see:

Downloading PyPy from "https://buildbot.pypy.org/nightly/py3.8/pypy-c-jit-latest-win64.zip" ...

Expected behavior:

A 32-bit binary is installed.

Actual behavior:
A 64-bit binary!

Activity

1. alex

   added

   bugSomething isn't workingSomething isn't working

   needs triage

   on Oct 9, 2022
2. nulano commented on Oct 9, 2022

   

   nulano

   on Oct 9, 2022

   More actions

   Expected behavior:
   A 32-bit binary is installed.

   There is no 32-bit Windows build of recent PyPy versions since PyPy 7.3.4.

   Actual behavior:
   A 64-bit binary!

   Whether this action should fail or silently switch to 64-bit is a separate question, related to #168 (comment) and #201.
3. alex commented on Oct 9, 2022

   

   alex

   on Oct 9, 2022

   Author

   More actions

   Hmm, indeed. I think this should be an error then, its very confusing to request one thing and get another -- in my case it produces confusing linker errors later on.
4. vsafonkin commented on Oct 10, 2022

   

   vsafonkin

   on Oct 10, 2022

   More actions

   Hi @alex, we will take a look at this, thank you for your report.
5. vsafonkin

   removed

   needs triage

   on Oct 10, 2022
6. vsafonkin

   self-assigned this

   on Oct 11, 2022
7. vsafonkin commented on Oct 18, 2022

   

   vsafonkin

   on Oct 18, 2022

   More actions

   Hi @alex, i've merged this PR to fix it. It's available via setup-python@main at the moment and will be available via version tag after a new release of setup-python action.
8. alex commented on Oct 18, 2022

   

   alex

   on Oct 18, 2022

   Author

   More actions

   great, thanks!

   Reacted by vs
9. vsafonkin commented on Oct 18, 2022

   

   vsafonkin

   on Oct 18, 2022

   More actions

   I'm going to close this issue, feel free to contact us if you have any concerns, thank you!
10. vsafonkin

    closed this as completedon Oct 18, 2022
11. graingert commented on Nov 3, 2024

    

    graingert

    on Nov 3, 2024

    More actions

    Hi @alex, i've merged this PR to fix it. It's available via setup-python@main at the moment and will be available via version tag after a new release of setup-python action.

    It looks like this wasn't fixed, specifying architecture: x86 still installs the x64 version rather than raising an error

Issue actions