GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add todo for ModuleConcatenationPlugin for loop bugfix · webpack/webpack@39095ef

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib/optimize
    • ModuleConcatenationPlugin.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/optimize/ModuleConcatenationPlugin.js‎

Copy file name to clipboardExpand all lines: lib/optimize/ModuleConcatenationPlugin.js
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,10 @@ class ModuleConcatenationPlugin {
281281
for (const reason of newModule.reasons) {
282282
reason.dependency.module = newModule;
283283
}
284+
// TODO: remove when LTS node version contains fixed v8 version
285+
// @see https://github.com/webpack/webpack/pull/6613
286+
// Turbofan does not correctly inline for-of loops with polymorphic input arrays.
287+
// Work around issue by using a standard for loop and assigning dep.module.reasons
284288
for (let i = 0; i < newModule.dependencies.length; i++) {
285289
let dep = newModule.dependencies[i];
286290
if (dep.module) {

0 commit comments

Comments
0 (0)
You are visitor 01402605 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.