GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Finder tuned: prefiltering for performance by ddobrigk · Pull Request #4452 · AliceO2Group/AliceO2

Conversation

@ddobrigk

@ddobrigk ddobrigk commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ddobrigk
Finder tuned: prefiltering for performance
310eaef
@ddobrigk
ddobrigk requested a review from jgrosseo as a code owner September 26, 2020 12:17
@jgrosseo

jgrosseo commented Sep 27, 2020

Copy link
Copy Markdown
Collaborator

@davidrohr @sawenzel If we want analyzers to consider the output of the checkcode test without our help, we have to improve its output. I don't even find the problem in the checkcode output in this PR. Could you let me know?
I propose we redo the output in a way, that the errors are printed at the beginning, and ideally the full build output goes to a different file where we just indicate the link. What do you think about this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgrosseo
jgrosseo previously approved these changes Sep 27, 2020
View reviewed changes
@jgrosseo

jgrosseo commented Sep 27, 2020

Copy link
Copy Markdown
Collaborator

ps - In case it is a false positive, please merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davidrohr

davidrohr commented Sep 27, 2020 via email

Copy link
Copy Markdown
Collaborator
There is already a summary for the checkcode errors. You can find it if you search the log for "list off". But I agree, it would make sense to move this to the beginning of the log.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ddobrigk

ddobrigk commented Sep 27, 2020

Copy link
Copy Markdown
Contributor Author

So, if I understand correctly this PR failed the o2checkcode because of me not adding underscores before capital letters in the middle of the names of table columns - is that it? ...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawenzel

sawenzel commented Sep 28, 2020

Copy link
Copy Markdown
Collaborator

@jgrosseo : Like for other builds the output shown is the complete log of the build process (I usually grep for "error"). In order to make this appear at the top or having it stand out, one would need to do adjustments in the CI logic I believe.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawenzel

sawenzel commented Sep 28, 2020

Copy link
Copy Markdown
Collaborator

@ddobrigk : Yes, the rule for namespaces (as described here https://github.com/AliceO2Group/CodingGuidelines/blob/master/naming_formatting.html) is Namespace names follow underscore convention and start with a lower case letter: <code>my_namespace</code>.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ddobrigk
Stick to naming convention
14049d8
@ddobrigk
ddobrigk dismissed jgrosseo’s stale review via 14049d8 September 28, 2020 12:48
@ddobrigk

ddobrigk commented Sep 28, 2020

Copy link
Copy Markdown
Contributor Author

@jgrosseo @sawenzel now changed to stick to naming convention. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgrosseo
jgrosseo approved these changes Sep 28, 2020
View reviewed changes
@jgrosseo
jgrosseo merged commit ec7f38d into AliceO2Group:dev Sep 28, 2020
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@ddobrigk @jgrosseo
Finder tuned: prefiltering for performance (AliceO2Group#4452)
81981a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ddobrigk @jgrosseo @davidrohr @sawenzel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.