GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Custom ripple xml for android 6 by jemshit · Pull Request #21 · AndroidDeveloperLB/MaterialPreferenceLibrary

This repository was archived by the owner on May 1, 2021. It is now read-only.

Conversation

@jemshit

@jemshit jemshit commented Feb 22, 2016

Copy link
Copy Markdown

Click event to center of list item still occurs sometimes even user clicks to corner of item. This removes double ripple effect when that occurs. Tested on android 4.1.2 , 4.4 , 5.0 , 6.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jemshit added 2 commits February 22, 2016 13:56
@jemshit
Removed double ripple effect on Android 6, using custom ripple for li…
f4727d7 
…st items. But still click event to corner of any list item occurs on the center of item sometimes.
@jemshit
Pre-lollipop compatible issue fixed
6d43215
@AndroidDeveloperLB

AndroidDeveloperLB commented Feb 22, 2016

Copy link
Copy Markdown
Owner

You mean you fixed this issue:
#19
?
I've tested it, and it shows a ripple in the center. I don't understand in which cases.
I'm not sure if I prefer it with this bug or the other one. :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jemshit

jemshit commented Feb 22, 2016

Copy link
Copy Markdown
Author

Yes, but there is still that weird click event even ripple effect looks correct. Try clicking to corner of first preference item on sample.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jemshit

jemshit commented Feb 22, 2016

Copy link
Copy Markdown
Author

And this doesn't add ripple for 2.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndroidDeveloperLB

AndroidDeveloperLB commented Feb 22, 2016

Copy link
Copy Markdown
Owner

What is the "weird click event" ? If it changes the behavior and not just
how it looks, please tell me.

About 2.x , I didn't mean it does. I was hoping you'd know how to make it
look at least like on ICS

On Mon, Feb 22, 2016 at 3:11 PM, Jemshit Iskenderov <
[email protected]> wrote:

And this doesn't add ripple for 2.x

—
Reply to this email directly or view it on GitHub
#21 (comment)
.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jemshit

jemshit commented Feb 22, 2016

Copy link
Copy Markdown
Author

Old sample demo video: http://sendvid.com/seggqpof
New demo: http://sendvid.com/08lju6xz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndroidDeveloperLB

AndroidDeveloperLB commented Feb 22, 2016

Copy link
Copy Markdown
Owner

yes, this is what I saw.
It's better than before, but it's not quite a fix, as it can show middle
ripple on some cases.
:(

On Mon, Feb 22, 2016 at 4:55 PM, Jemshit Iskenderov <
[email protected]> wrote:

Old sample demo video: http://sendvid.com/seggqpof
New demo: http://sendvid.com/08lju6xz

—
Reply to this email directly or view it on GitHub
#21 (comment)
.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AndroidDeveloperLB added a commit that referenced this pull request Feb 25, 2016
@AndroidDeveloperLB
Merge pull request #21 from jemshit/master
a3ef8e8 
Almost fixed ripple effect issue on android 6 when pressing preferences items. See this: #19
Also, for some reason, now it sometimes show the ripple in the middle.
@AndroidDeveloperLB
AndroidDeveloperLB merged commit a3ef8e8 into AndroidDeveloperLB:master Feb 25, 2016
@AndroidDeveloperLB

AndroidDeveloperLB commented Mar 3, 2016

Copy link
Copy Markdown
Owner

Question:
why for "mpl__custom_ripple_effect_background.xml" inside "drawable", you made all states show transparent color, instead of just a single item that show transparent (first one) ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AndroidDeveloperLB

AndroidDeveloperLB commented Mar 5, 2016

Copy link
Copy Markdown
Owner

anyway, fixed this issue on version 7.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jemshit @AndroidDeveloperLB
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.