GeezerVison is showing github.com — close CacheStore in CacheManager.dispose and cancel internal timer by EdwynZN · Pull Request #418 · Baseflow/flutter_cache_manager
Conversation
EdwynZN
commented
May 30, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug Fix
⤵️ What is the current behavior?
When closing the CacheManager (using whatever state management or manually Provider, Bloc, Riverpod, etc) and the internal clean up schedule timer of the store is still running there is an Exception thrown by the CacheInfoRepository if its implemented by an SQL/NoSQL package (Hive for example) because it tries to use a repository that is already closed
🆕 What is the new behavior (if this is a feature change)?
CacheManager closes the internal store and by doing that, the store closes the repository used and also stops the timer in case it's running
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Close the cacheManager after using it
📝 Links to relevant issues/docs
🤔 Checklist before submitting
- All projects build
- Follows style guide lines (code style guide)
- Relevant documentation was updated
- Rebased onto current develop
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.