GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update intent names by Plerx2493 · Pull Request #1610 · DSharpPlus/DSharpPlus

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Aug 29, 2023

Copy link
Copy Markdown
Member

Summary

Updates the Gateway intent names according to the docs

Details

  • GuildBans changed to GuildModeration: Contains now the auditlog entry created event
  • GuildEmojis to GuildEmojisAndStickers
  • editorconfig applied

Notes

This is a breaking change! Most additions and deletions are whitespace changes. Should be merged after #1586 so it can ref the new event in the xmldocs
Any additional notes go here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Plerx2493
Update intent names
41e0ec1
@Plerx2493

Plerx2493 commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

Should i also apply the editorconfig in the two other files?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akiraveliara

akiraveliara commented Aug 29, 2023

Copy link
Copy Markdown
Member

#1586 is merged; but yes, reformat every file you touch please
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493

Plerx2493 commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

My bad c&p from the old pr ^^
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
apply editorconfig
f065de1
@Plerx2493

Plerx2493 commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

Ready to merge, we maybe should anounce it as a breaking change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akiraveliara

akiraveliara commented Aug 29, 2023

Copy link
Copy Markdown
Member

you should have typing perms in announcements
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akiraveliara

akiraveliara commented Aug 29, 2023

Copy link
Copy Markdown
Member

also, please mark as ready for review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akiraveliara akiraveliara added enhancement core v5.x labels Aug 29, 2023
@Plerx2493
Plerx2493 marked this pull request as ready for review August 29, 2023 15:34
@akiraveliara
akiraveliara merged commit c8a8940 into DSharpPlus:master Aug 29, 2023
@Plerx2493

Plerx2493 commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

doesnt seem so
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
Plerx2493 deleted the fix/intents branch August 29, 2023 15:35
@DubyaDude DubyaDude mentioned this pull request Aug 30, 2023
v5 breaking changes tracking issue #1585
Open
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@Plerx2493
Update intent names (#1610)
2f674cd 
* Update intent names

* apply editorconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Plerx2493 @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.