GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — AuditlogParser update by Plerx2493 · Pull Request #1612 · DSharpPlus/DSharpPlus

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Sep 3, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

  • Adds missing keys to channelUpdate auditlog entries
  • Fix weird casts
  • update PropertyChange
  • Performance upgrades
  • Auditlogs are now parsed and returned as a IAsyncEnumerable
  • Fixes DiscordAuditLogMessageEntry.Target property is of wrong type. #1569

Notes

https://discord.com/channels/379378609942560770/379386901725052928/1147974237735366818

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Plerx2493
Add missing flags and userLimit changes
99deeaf
@Plerx2493 Plerx2493 added enhancement audit-log Issues about missing auditlog types or missing change key labels Sep 3, 2023
@Plerx2493
fix casting
07fb7a7
@Plerx2493 Plerx2493 changed the title Add missing flags and userLimit changes AuditlogParser update Sep 3, 2023
@Plerx2493
Plerx2493 marked this pull request as draft September 4, 2023 11:30
Plerx2493 added 6 commits September 5, 2023 02:30
@Plerx2493
AuditLogParser cleanup
3f624cf
@Plerx2493
Added missing keys and refactoring
36a7138
@Plerx2493
remove debug/testing stuff
feaa0db
@Plerx2493
IAsyncEnumerable
223d09f
@Plerx2493
fix DSharpPlus#1569
aaf97fe
@Plerx2493
add missing property change on channel entries
50615a5
@Plerx2493
Plerx2493 marked this pull request as ready for review September 12, 2023 15:53
@Plerx2493
Plerx2493 requested a review from akiraveliara September 12, 2023 15:53
@Plerx2493
rename some method parameters to follow editorconfig
cf9250f
@akiraveliara akiraveliara added the v5.x label Sep 12, 2023
akiraveliara
akiraveliara requested changes Sep 12, 2023
View reviewed changes

@akiraveliara akiraveliara left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three naming issues, other than that lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread DSharpPlus/Entities/Guild/DiscordGuild.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DSharpPlus/Entities/Guild/DiscordGuild.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread DSharpPlus/Entities/Guild/DiscordGuild.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
revert misclick
dca96c7
@akiraveliara
akiraveliara self-requested a review September 12, 2023 16:43
akiraveliara
akiraveliara approved these changes Sep 12, 2023
View reviewed changes
@akiraveliara
akiraveliara merged commit ef4949f into DSharpPlus:master Sep 12, 2023
@Plerx2493
Plerx2493 deleted the fix/auditKeys branch September 12, 2023 16:43
@Plerx2493 Plerx2493 mentioned this pull request Sep 12, 2023
v5 breaking changes tracking issue #1585
Open
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@Plerx2493
AuditlogParser update (#1612)
6928f9e 
* Add missing flags and userLimit changes

* fix casting

* AuditLogParser cleanup

* Added missing keys and refactoring

* remove debug/testing stuff

* IAsyncEnumerable

* fix #1569

* add missing property change on channel entries

* rename some method parameters to follow editorconfig

* revert misclick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akiraveliara akiraveliara akiraveliara approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

audit-log Issues about missing auditlog types or missing change key enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DiscordAuditLogMessageEntry.Target property is of wrong type.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Plerx2493 @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.