GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove deprecated code, attempt 2 by inftord · Pull Request #1616 · DSharpPlus/DSharpPlus

Conversation

@inftord

@inftord inftord commented Sep 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Make sure you familiarize yourself with our contributing guidelines.

Summary

Removes a bunch of deprecated code.

Changes proposed

  • AckPaginationButtons was removed due to being longer used or possible to implement.
  • TargetUserType is obsolete, TargetType should be used instead.
  • Three obsolete permissions were removed from Permissions enum
  • User TokenType isn't supported by Discord and can get your account terminated ,and was declared obsolete in code.

Notes

attempt 2

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@inftord
remove deprecated code, attempt 2
9fb9e79
@akiraveliara

akiraveliara commented Sep 12, 2023

Copy link
Copy Markdown
Member

do not remove the SendPayloadAsync methods. also read the obsoletion message
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akiraveliara akiraveliara added core v5.x labels Sep 12, 2023
@inftord
get sendpayloadasync methods back
e5f159d
@akiraveliara
akiraveliara merged commit 6b0e24a into master Sep 12, 2023
@akiraveliara
akiraveliara deleted the inf/remove/deprecated branch September 12, 2023 14:38
@akiraveliara akiraveliara mentioned this pull request Sep 12, 2023
v5 breaking changes tracking issue #1585
Open
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@inftord
remove deprecated code, attempt 2 (#1616)
6748cce 
* remove deprecated code, attempt 2

* get sendpayloadasync methods back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@inftord @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.