GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Major DiscordShardedClient update/maintaining by Plerx2493 · Pull Request #1619 · DSharpPlus/DSharpPlus

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Sep 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

Events were not updated in the sharded client

Details

Some events were missing completely and some had missing implementation. Also the event renaming on the DiscordClient was not changed here. Created a "SGen" tool to reflect automaticly the events from the non-sharded client. @OoLunar wants to link this tool with a gh action in the future

Note

I will look if i can make further updates

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Plerx2493
Add missing events, registration and started sorting (better maintain…
d1d8619 
…ing in the future)
@Plerx2493 Plerx2493 added enhancement core big-change v5.x labels Sep 14, 2023
Plerx2493 added 2 commits September 17, 2023 04:54
@Plerx2493
Add "SourceGenerator" console application
965bfeb
@Plerx2493
fix encoding
677d658
@OoLunar

OoLunar commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Please rebase master to fix the runner build errors
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OoLunar

OoLunar commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Also I might rewrite your ShardedEventHandlingGen tool later on to be easily reusable with more "sgen" scenarios
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Plerx2493 added 2 commits September 18, 2023 22:53
@Plerx2493
Merge branch 'master' into fix/shardedClient
cc9de22 
# Conflicts:
#	Directory.Packages.props
@Plerx2493
Add export to file
8ea24d7
@Plerx2493

Plerx2493 commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

Should be ready now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493

Plerx2493 commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

Also I might rewrite your ShardedEventHandlingGen tool later on to be easily reusable with more "sgen" scenarios

If you have specific changes in mind i would do it myself
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OoLunar

OoLunar commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Something like this, except maybe a little more fleshed out.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
Plerx2493 requested a review from akiraveliara September 19, 2023 18:45
@Plerx2493
Plerx2493 marked this pull request as ready for review September 19, 2023 18:47
akiraveliara
akiraveliara approved these changes Sep 20, 2023
View reviewed changes

@akiraveliara akiraveliara left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about humanizer, but looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/DSharpPlus.Tools.ShardedEventHandlingGen/Program.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@OoLunar

OoLunar commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

This PR has a lot of potential in it. There are a few changes I'd like to make. I'd be okay with merging this as it is now though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
purge Humanizer
2dcf4ad
@akiraveliara

akiraveliara commented Sep 20, 2023

Copy link
Copy Markdown
Member

fine to merge, @OoLunar ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OoLunar

OoLunar commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

Yeah good to merge. It'll be a bit before I make my changes in a separate PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493

Plerx2493 commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

wait
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493

Plerx2493 commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

private event names are now _EventName instead of _eventName
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493

Plerx2493 commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

I think i should fix this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OoLunar

OoLunar commented Sep 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Please just send everything in one comment, each of those comments are being sent to my email.

It's up to you if you want to fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Plerx2493
ToLower, ToUpper .....
4602cb6
@OoLunar
OoLunar merged commit 4b48d55 into DSharpPlus:master Sep 20, 2023
@Plerx2493 Plerx2493 mentioned this pull request Sep 20, 2023
v5 breaking changes tracking issue #1585
Open
@Plerx2493
Plerx2493 deleted the fix/shardedClient branch October 5, 2023 13:49
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@Plerx2493
Major DiscordShardedClient update/maintaining (#1619)
a9bd029 
* Add missing events, registration and started sorting (better maintaining in the future)

* Add "SourceGenerator" console application

* fix encoding

* Add export to file

* purge Humanizer

* ToLower, ToUpper .....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akiraveliara akiraveliara akiraveliara approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

big-change core enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Plerx2493 @OoLunar @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.