GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — getMessages returns now a IAsyncEnumerable by Plerx2493 · Pull Request #1641 · DSharpPlus/DSharpPlus

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Oct 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Summary

Implement the methods as IAsyncEnumerable

Details

Untested, i will test i tomorrow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Plerx2493 added 2 commits October 6, 2023 00:26
@Plerx2493
getMessages returns now a IAsyncEnumerable
9c3a5be
@Plerx2493
erm
9429cac
@Plerx2493 Plerx2493 added this to the v5.0 milestone Oct 5, 2023
Plerx2493 added 2 commits October 6, 2023 16:09
@Plerx2493
Reverse loop instead of collection
41f0049
@Plerx2493
Fix/ratelimit policy (#1642)
a2424cf
* TrygetHeader and is exemptFromGlobalLimit check

* erm
@Plerx2493 Plerx2493 added enhancement core labels Oct 7, 2023
Plerx2493 added 5 commits October 7, 2023 12:39
@Plerx2493
Fix issue with ratelimiting (#1643)
1e63855
* update polly

* Build request for each try

* erm idk

* all i have to say then is "please using the request message"

* only one req
@Plerx2493
getMessages returns now a IAsyncEnumerable
f3278f1
@Plerx2493
erm
d0ae6eb
@Plerx2493
Reverse loop instead of collection
ada11b9
@Plerx2493
Merge remote-tracking branch 'origin/fix/getMessages' into fix/getMes…
c1437f9
…sages
@Plerx2493
Plerx2493 marked this pull request as ready for review October 7, 2023 13:50
@akiraveliara
akiraveliara merged commit 603876b into master Oct 7, 2023
@Plerx2493 Plerx2493 mentioned this pull request Oct 7, 2023
v5 breaking changes tracking issue #1585
Open
@Plerx2493
Plerx2493 deleted the fix/getMessages branch October 7, 2023 14:05
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@Plerx2493
getMessages returns now a IAsyncEnumerable (#1641)
abb092c
* getMessages returns now a IAsyncEnumerable

* erm

* Reverse loop instead of collection

* Fix/ratelimit policy (#1642)

* TrygetHeader and is exemptFromGlobalLimit check

* erm

* Fix issue with ratelimiting (#1643)

* update polly

* Build request for each try

* erm idk

* all i have to say then is "please using the request message"

* only one req

* getMessages returns now a IAsyncEnumerable

* erm

* Reverse loop instead of collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core enhancement

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Plerx2493 @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.