GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — IAsyncEnumerble returns for GetAllMembersAsync and GetEventUsersAsync by Plerx2493 · Pull Request #1644 · DSharpPlus/DSharpPlus

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Oct 7, 2023

Copy link
Copy Markdown
Member

Summary

Rewrote paginated methods to use IAsyncEnumerable

Details

This is a breaking change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Plerx2493
IAsyncEnumerble returns for GetAllMembersAsync and GetEventUsersAsync
3556c69
@Plerx2493
Plerx2493 requested a review from akiraveliara October 7, 2023 15:01
@Plerx2493 Plerx2493 added enhancement core labels Oct 7, 2023
@Plerx2493 Plerx2493 added this to the v5.0 milestone Oct 7, 2023
akiraveliara
akiraveliara approved these changes Oct 7, 2023
View reviewed changes
@Plerx2493
Plerx2493 marked this pull request as ready for review October 7, 2023 17:14
@Plerx2493
Plerx2493 merged commit b7e6630 into master Oct 7, 2023
@Plerx2493
Plerx2493 deleted the feat/IAsyncEnumerable branch October 7, 2023 17:14
@Plerx2493 Plerx2493 mentioned this pull request Oct 7, 2023
v5 breaking changes tracking issue #1585
Open
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@Plerx2493
IAsyncEnumerble returns for GetAllMembersAsync and GetEventUsersAsync (…
ae7fba0 
…#1644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akiraveliara akiraveliara akiraveliara approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core enhancement

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Plerx2493 @akiraveliara
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.