GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — enable nullability on DiscordApplication and related types by akiraveliara · Pull Request #1672 · DSharpPlus/DSharpPlus

Conversation

@akiraveliara

@akiraveliara akiraveliara commented Nov 9, 2023

Copy link
Copy Markdown
Member

ticks the first check box on #1653
also covering:

  • DiscordApplicationAsset
  • DiscordAsset
  • DiscordSpotifyAsset

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
akiraveliara added 2 commits November 9, 2023 18:08
@akiraveliara
annotate for nullability, deal with analyzer warnings
9325e16
@akiraveliara
move the types to their own files
345b48c
@akiraveliara akiraveliara added enhancement core epic-nullability for pull requests and issues relating to enabling nullability in v5 labels Nov 9, 2023
@akiraveliara akiraveliara added this to the v5.0 milestone Nov 9, 2023
@akiraveliara
akiraveliara requested a review from Plerx2493 November 9, 2023 17:23
Plerx2493
Plerx2493 approved these changes Nov 9, 2023
View reviewed changes
@Plerx2493
Plerx2493 merged commit 07a9233 into master Nov 10, 2023
@akiraveliara akiraveliara mentioned this pull request Nov 10, 2023
v5 breaking changes tracking issue #1585
Open
@akiraveliara
akiraveliara deleted the nullability/application branch November 10, 2023 16:07
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@akiraveliara
enable nullability on DiscordApplication and related types (#1672)
39eda78 
* annotate for nullability, deal with analyzer warnings

* move the types to their own files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Plerx2493 Plerx2493 Plerx2493 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core enhancement epic-nullability for pull requests and issues relating to enabling nullability in v5

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@akiraveliara @Plerx2493
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.