GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — switch GetReactionsAsync to IAsyncEnumerable by akiraveliara · Pull Request #2037 · DSharpPlus/DSharpPlus

Conversation

@akiraveliara

@akiraveliara akiraveliara commented Jul 24, 2024

Copy link
Copy Markdown
Member

in line with our other paginated requests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@akiraveliara
switch GetReactionsAsync to IAsyncEnumerable
e8eb29a
@akiraveliara akiraveliara added enhancement core labels Jul 24, 2024
@akiraveliara akiraveliara added this to the v5.0 milestone Jul 24, 2024
@akiraveliara
remove unused old impl
d1f3d75
Plerx2493
Plerx2493 approved these changes Jul 24, 2024
View reviewed changes

@Plerx2493 Plerx2493 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtm if tested

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@akiraveliara
akiraveliara merged commit a0d828d into master Jul 24, 2024
@akiraveliara
akiraveliara deleted the aki/get-reactions-asyncenumerable branch July 24, 2024 11:50
@akiraveliara akiraveliara mentioned this pull request Jul 24, 2024
v5 breaking changes tracking issue #1585
Open
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
@akiraveliara
switch GetReactionsAsync to IAsyncEnumerable (#2037)
b84ef58 
* switch GetReactionsAsync to IAsyncEnumerable

* remove unused old impl
Instellate pushed a commit that referenced this pull request Nov 4, 2024
@akiraveliara @Instellate
switch GetReactionsAsync to IAsyncEnumerable (#2037)
a2335e6 
* switch GetReactionsAsync to IAsyncEnumerable

* remove unused old impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Plerx2493 Plerx2493 Plerx2493 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

core enhancement

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@akiraveliara @Plerx2493
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.