GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Show alarm controller state in status icons by jmlich · Pull Request #1884 · InfiniTimeOrg/InfiniTime

Conversation

@jmlich

@jmlich jmlich commented Oct 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I would like to know if the alarm is active on Watch Face Digital screen.

I made an prototype with InfiniSim and it looks that it works as expected:

screenshot-alarm-indicator InfiniSim_2024-12-22_141530

However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
minacode, KaffeinatedKat, LinuxinaBit, tausen, marigoldfish, and rnwgnr reacted with thumbs up emoji
All reactions
  • 👍 6 reactions
@github-actions

github-actions Bot commented Oct 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 372944B 128B
data 948B 0B
bss 22536B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich
jmlich force-pushed the main branch from 844ef9b to aab333c Compare October 8, 2023 12:14
minacode
minacode reviewed Oct 8, 2023
View reviewed changes

@minacode minacode left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this feature! :)

You should be very safe to test this on a sealed device (speaking from experience).
If something goes wrong, which shouldn't happen, you can always:

  • reboot to get back to your last firmware (don't verify your debug flash of course)
  • hold the button pressed until the color changed twice during boot to get to the fallback firmware and update your watch from there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/displayapp/widgets/StatusIcons.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jmlich
jmlich force-pushed the main branch from aab333c to bae20c0 Compare October 9, 2023 06:21
@jmlich

jmlich commented Oct 21, 2023

Copy link
Copy Markdown
Contributor Author

I have also tested the feature on hardware.
minacode and rnwgnr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LinuxinaBit

LinuxinaBit commented Nov 9, 2023

Copy link
Copy Markdown

I like this, but I think the icon has a little too much filled space and the simple circle isn’t as defined as a more standard alarm icon:
image
Of course these might not work with a resolution that small, but I’m sure something similar could…
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich

jmlich commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.
rnwgnr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LinuxinaBit

LinuxinaBit commented Nov 9, 2023 via email

Copy link
Copy Markdown
Ah, I forgot it was already the icon for the alarm app. Sorry about that.
…
On November 9, 2023 9:30:26 AM CST, Jozef Mlich ***@***.***> wrote: I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon. I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request. -- Reply to this email directly or view it on GitHub: #1884 (comment) You are receiving this because you commented. Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JF002
JF002 self-requested a review November 26, 2023 17:31
@jmlich
jmlich force-pushed the main branch from aa7b789 to 7d6ba8d Compare December 16, 2023 14:45
@vkareh

vkareh commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

This should be rebased against main and updated to reflect the new icon from #1996
rnwgnr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich jmlich mentioned this pull request Jun 12, 2024
Alarm status on infineat #2068
Open
@rnwgnr

rnwgnr commented Aug 15, 2024

Copy link
Copy Markdown

@jmlich I'd like to give this change a try, would you mind rebasing this changeset against the current state of main?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich
jmlich force-pushed the main branch 2 times, most recently from 54190ac to f0e01cb Compare August 24, 2024 08:24
@jmlich

jmlich commented Aug 24, 2024

Copy link
Copy Markdown
Contributor Author

Rebased to recent main
rnwgnr and minacode reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jmlich
jmlich force-pushed the main branch 5 times, most recently from 15fb52c to e2ff1b2 Compare December 22, 2024 13:05
@jmlich

jmlich commented Dec 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Rebased to recent main. The screenshot and screencast in pull request description was updated as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Dec 22, 2024
mark9064
mark9064 reviewed Dec 22, 2024
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/displayapp/widgets/StatusIcons.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jmlich
jmlich force-pushed the main branch from e2ff1b2 to 4ed3671 Compare December 22, 2024 13:48
@jmlich
Show alarm controller state in status icon
06e0d5d
@jmlich
jmlich force-pushed the main branch from 4ed3671 to 06e0d5d Compare December 22, 2024 13:51
mark9064
mark9064 approved these changes Dec 22, 2024
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! I still need to test on hardware, other than that all good to go from me :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mark9064 mark9064 added this to the 1.16.0 milestone Dec 22, 2024
vkareh
vkareh approved these changes Dec 22, 2024
View reviewed changes

@vkareh vkareh left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've been using this on hardware in my daily driver branch for many months

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mark9064 and rnwgnr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
JF002
JF002 approved these changes Jan 5, 2025
View reviewed changes

@JF002 JF002 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jmlich reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@JF002
JF002 merged commit 3e23ee7 into InfiniTimeOrg:main Jan 5, 2025
@JustScott JustScott mentioned this pull request Jan 18, 2025
Add Timer's Time Remaining to StatusIcons #1967
Open
@tituscmd tituscmd mentioned this pull request Oct 26, 2025
Added active alarm indicator to watch face #2355
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minacode minacode minacode left review comments
@JF002 JF002 JF002 approved these changes
@mark9064 mark9064 mark9064 approved these changes
+1 more reviewer
@vkareh vkareh vkareh approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jmlich @LinuxinaBit @vkareh @rnwgnr @JF002 @minacode @mark9064
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.