GeezerVison

Build size and comparison to main:

Run in InfiniEmu

@JustScott

Looking for opinions on possible changes to the timer's and symbol's font color and/or position.

I like this feature a lot, as I use the timer regularly. Since you asked for opinions, how about making it part of the StatusIcons? This way you can see it in several other screens. Although maybe this makes it look too busy. Not sure, but just a suggestion.

@vkareh Here's how the timer would look as a StatusIcon:

There are currently 2 issues with this:

1. The status icons are only set to update when switching between screens in the Tile.cpp file, which means the time remaining will only update once each time you swipe between screens. This could be changed to update more often like is done on the clock faces, but I'm unsure of how this would effect power consumption.
2. The timer is shown on the digital watch face screen both in the status icons and above the current time. We could have just avoided placing it in the watch face itself, and only placed it in the status icons with the change suggested in issue 1 above... but this would now take the same position as the new weather widget. So the obvious solution is just to detect if the current open app is the digital watch face, and set the timer to hidden.

I'll implement these fixes/changes, but first I'd like some feedback on whether this is something people actually want. I personally think it could be nice, but honestly I don't see myself needing to know how much time is remaining on a timer in the second it takes me to switch between apps (but some people may).

The timer is shown on the digital watch face screen both in the status icons and above the current time. We could have just avoided placing it in the watch face itself, and only placed it in the status icons with the change suggested in issue 1 above... but this would now take the same position as the new weather widget. So the obvious solution is just to detect if the current open app is the digital watch face, and set the timer to hidden.

I've been using a version of the digital face with the weather within the face itself:

I think this change would go nicely with the timer in the status bar.

The status icons are only set to update when switching between screens in the Tile.cpp file, which means the time remaining will only update once each time you swipe between screens. This could be changed to update more often like is done on the clock faces, but I'm unsure of how this would effect power consumption.

This is a problem. It could be solved by adding decreasing the task refresh period like this (not tested):

diff --git a/src/displayapp/screens/Tile.cpp b/src/displayapp/screens/Tile.cpp
index 7c585a4b..ffdb9f44 100644
--- a/src/displayapp/screens/Tile.cpp
+++ b/src/displayapp/screens/Tile.cpp
@@ -87,7 +87,7 @@ Tile::Tile(uint8_t screenID,
   btnm1->user_data = this;
   lv_obj_set_event_cb(btnm1, event_handler);
 
-  taskUpdate = lv_task_create(lv_update_task, 5000, LV_TASK_PRIO_MID, this);
+  taskUpdate = lv_task_create(lv_update_task, 500, LV_TASK_PRIO_MID, this);
 
   UpdateScreen();
 }

500ms lets you see the timer seconds real time and it shouldn't really affect power consumption that much, I think, since the status icons only show up in screens that support auto-sleep of the display.

@vkareh Ah I missed the part where the status icons update every 5 seconds. I think moving this timer to the status icons would be the best solution if the weather icon is moved as shown in your image above. I'll try this out.

Alright I moved the timer from right above the time on the digital watchface, to the StatusIcons 'area'.

Also, I'm VERY new to C++, and was just following what looked to be the right way to pass this timer controller around, but I feel it got added to too many places... so feedback on whether the code is correct or not would be much appreciated. To me it seems like it would be best if I could just define the timer controller within StatusIcons.cpp instead of having to pass it to every StatusIcons class call.

I created a PR to move the weather widget: #1998

I've applied the changes from all of vkareh's reviews, and have been using this without issue for quite a while now. Here's some images of how it looks with the digital watch face weather changes. @JF002 would this be something you'd be interested in including in version 1.16.0?

Adjusted the code to work with the new alarm icon in the status icons from #1884. To prevent crowding I moved the timer over a hair:

It doesn't align well with the weather in the digital watch face... but I didn't think it aligned all that well before either:

I've moved the timeRemaining and timerIcon to there own timerContainer, and moved that container into the primary container to allow them to dynamically align with the other icons, while being able to place them closer together than the others. When more than two icons (exluding batteryIcon) are made visible, the timerContainer is set to hidden and a soloTimerIcon is made visible. Replacing the live timer with a simple icon allows the user to avoid any overlapping with the time in the top left when many icons are visible, while still letting them know a timer is active... and when a few icons go back to being hidden, the live timer will be made visible again.

I feel the space between the time and the AM and PM is a bit unecessary and ugly, this is how it would look without the space. I can change it in this PR, or it can be left to another PR... just thought I would show the difference.

There could be another icon allowed with the 24 hour time format, but this would require bringing the settingsController in... I'm not opposed to it, but it seems unecessary

Maybe to save space the timer could shorten to XXm/XXs?

Maybe to save space the timer could shorten to XXm/XXs?

Incredible timing, I was just working on something like this.

Minutes are now only shown if greate than 0. Another icon is also allowed if the user is using 24H time instead of 12H time.

If you want to be more aggressive, I'd even remove the colon : when it's just seconds remaining. Seems unnecessary and shaves off a whole character.

This looks great, BTW, and I use this feature every day. Looking forward to rebasing the new look into my daily-driver branch.

If you want to be more aggressive, I'd even remove the colon : when it's just seconds remaining. Seems unnecessary and shaves off a whole character.

Removed the colon, looks better to me:

Reduced timer letter spacing to save space

Allows up to four icons (using an example stopWatch icons for the fourth icon):

Another example with hour support from PR #2243:

Most aggressive would be to replace the current time with the time remaining for as long as the timer is running 😄