GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Heartrate app displays --- instead of 000 by KaffeinatedKat · Pull Request #1887 · InfiniTimeOrg/InfiniTime

Conversation

@KaffeinatedKat

@KaffeinatedKat KaffeinatedKat commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Fixes #1881, when the heartrate data is not clear, or there is no measurement, display --- instead of 000

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LinuxinaBit, watertrainer, tullydwyer, 1Maxnet1, tituscmd, mark9064, and NitroNils reacted with thumbs up emoji
All reactions
  • 👍 7 reactions
KaffeinatedKat and others added 2 commits October 11, 2023 08:25
@KaffeinatedKat
fix: heartrate app displays --- instead of 000
4a077a6
@KaffeinatedKat
Merge branch 'main' into hr
4f714ca
@github-actions

github-actions Bot commented Oct 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 377616B 0B
data 940B 0B
bss 63492B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
FintasticMan
FintasticMan approved these changes Nov 17, 2023
View reviewed changes

@FintasticMan FintasticMan left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it more clear to the user what the situation is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FintasticMan
FintasticMan requested a review from a team November 17, 2023 13:11
@FintasticMan FintasticMan added the UI/UX User interface/User experience label Nov 17, 2023
@KaffeinatedKat
Merge branch 'main' into hr
6410a17
NeroBurner
NeroBurner reviewed Nov 17, 2023
View reviewed changes
Comment thread src/displayapp/screens/HeartRate.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@KaffeinatedKat
Merge branch 'main' into hr
ea456fc
@mark9064

mark9064 commented Apr 11, 2024

Copy link
Copy Markdown
Member

Does exactly what it says on the tin, haven't had any issues. Seems good to go UX wise to me
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
NeroBurner
NeroBurner approved these changes Apr 12, 2024
View reviewed changes
@NeroBurner
NeroBurner merged commit 6b5235c into InfiniTimeOrg:main Apr 12, 2024
Eve1374 pushed a commit to Eve1374/InfiniTime that referenced this pull request May 30, 2024
@KaffeinatedKat @Eve1374
fix: heartrate app displays --- instead of 000 (InfiniTimeOrg#1887)
80b4da8
@FintasticMan FintasticMan added this to the 1.15.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FintasticMan FintasticMan FintasticMan approved these changes
@NeroBurner NeroBurner NeroBurner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

UI/UX User interface/User experience

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Heartrate Value jumps to 000

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@KaffeinatedKat @mark9064 @NeroBurner @FintasticMan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.