GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WatchFaceDigital: Move weather widget away from status icons by vkareh · Pull Request #1998 · InfiniTimeOrg/InfiniTime

Conversation

@vkareh

@vkareh vkareh commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

The weather widget is too high and could overlap the status icons. Moving it to match the rest of the face avoids this issue and makes it align with the rest of the theme.

InfiniSim_2024-02-01_171503

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tituscmd and z3t0 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@github-actions

github-actions Bot commented Feb 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 373140B 16B
data 940B 0B
bss 63516B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vkareh vkareh mentioned this pull request Feb 1, 2024
Add Timer's Time Remaining to StatusIcons #1967
Open
FintasticMan
FintasticMan reviewed Feb 1, 2024
View reviewed changes
Comment thread src/displayapp/screens/WatchFaceDigital.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
FintasticMan
FintasticMan approved these changes Feb 2, 2024
View reviewed changes
@FintasticMan FintasticMan added the UI/UX User interface/User experience label Feb 7, 2024
@vkareh
WatchFaceDigital: Move weather widget away from status icons
842f854 
The weather widget is too high and could overlap the status icons.
Moving it to match the rest of the face avoids this issue and makes it
align with the rest of the theme.
@vkareh
vkareh force-pushed the face-digital-weather-position branch from 1f0d628 to 842f854 Compare February 7, 2024 14:14
JF002
JF002 approved these changes Feb 11, 2024
View reviewed changes
@JF002 JF002 added this to the 1.15.0 milestone Feb 11, 2024
@JF002
JF002 merged commit a49dc15 into InfiniTimeOrg:main Feb 11, 2024
@vkareh
vkareh deleted the face-digital-weather-position branch February 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes
@FintasticMan FintasticMan FintasticMan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

UI/UX User interface/User experience

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vkareh @JF002 @FintasticMan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.