GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — README: Header redesign by liamcharger · Pull Request #2032 · InfiniTimeOrg/InfiniTime

Conversation

liamcharger commented Feb 28, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This PR enhances the visual appeal of the main README.md header with a restyled header design. Open to feedback and suggestions for further improvements!

Additionally, in the README body, I've included a reference to InfiniTimeExplorer since its existence is not widely known.

Please refer to my InfiniTime fork for a preview of the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JumpLink, jmlich, minacode, Elements6007, arvchristos, PerilousBooklet, pipe01, NeroBurner, tituscmd, and Koloss0 reacted with heart emoji

All reactions

❤️ 10 reactions

liamcharger added 17 commits

February 26, 2024 12:28


          Reformat README.md

1362e04


          Update README.md

8305e92


          Add files via upload

4eef9e0


          Add files via upload

fab4a46


          Add new README.md header image

07a1030


          Remove unnecessary <br> tag

9388ce4


          Scale watchface logo down; add downloads badge

6000f71


          Remove unnecessary <br> tag

4def1e7


          Add <br> tag to maintain spacing consistency

ebfcc17


          Remove incorrect link

ab0be0e


          Add watchface logo with dark logo

b60ddc9


          Replace logo image with dark version

54d4a91


          Add files via upload

f39ba77


          Add header image

875bde3


          Fix row spacing in header image

a9d6345


          Remove unnecessary <br> tag

f0d5f87


          Add corner radius to header image

cd462ac

liamcharger changed the title ~~Restyle README.md~~ README: Header redesign

Mar 1, 2024

rambonette commented Mar 5, 2024

Copy link

Copy Markdown

Looks very nice imo 👏

arvchristos and PerilousBooklet reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger added 11 commits

March 5, 2024 08:40


          Add files via upload

e96e529


          Update image background

a4eb5a2


          Add reference to InfiniTimeExplorer

3aa11d3


          Remove unnecessary image

22c1290


          Remove unnecessary image

f4cfe9a


          Remove unnecessary images

4d19fd8


          Rename watchface_collage_no_shadow.png to watchface_collage.png

ce05adc


          Update header image URL

954677c


          Remove unnecessary <br> tag

f16033f


          Merge branch 'InfiniTimeOrg:main' into main

e9a1ca7


          Merge branch 'main' into main

3eea3dd


          Merge branch 'main' into main

9bba786

liamcharger commented Oct 1, 2024

Copy link

Copy Markdown

Contributor Author

this looks great! I didn't know you could combine html tags with markdown

I especially like the collage. I'm curious, how did you create it?

Glad you like it! I did it in Adobe Photoshop by taking several screenshots from InfiniSim ;) and then merging each screen with a representation of the physical watch that was used in InfiniLink. Then I positioned everything, added the screen that's stacked on the others, and lastly, I added a circle with a Gaussian blur behind everything for the shadow effect.

NeroBurner reacted with rocket emoji

NeroBurner reacted with eyes emoji

All reactions

🚀 1 reaction
👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tituscmd commented Oct 1, 2024

Copy link

Copy Markdown

Contributor

This is beautiful. Great work!

liamcharger reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064 reviewed

Oct 19, 2024

View reviewed changes

mark9064 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really pretty :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

FintasticMan commented Oct 19, 2024

Copy link

Copy Markdown

Member

I like the way it looks, but I do find it a bit strange that the yellow in the picture is darker than it "should" be.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into main

2e28f62

liamcharger commented Oct 19, 2024

Copy link

Copy Markdown

Contributor Author

I do find it a bit strange that the yellow in the picture is darker than it "should" be.

Not sure if it really matters, but do you mean the yellow in the InfiniTime logo?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          README: improve wording

05d4e87

FintasticMan commented Oct 19, 2024

Copy link

Copy Markdown

Member

Yeah, the yellow in the InfiniTime logo is darker than other places we use it. It looks like the colours are inverted actually, so I can see how it happened. I feel like maybe you could use the picture we use for the recovery firmware, that's on a black background.

liamcharger reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger added 2 commits

October 21, 2024 12:58


          Add bootloader to DeviceInformationService.cpp

35570ed


          Add bootloader to DeviceInformationService.h

f3f0fd5

FintasticMan commented Oct 21, 2024

Copy link

Copy Markdown

Member

@liamcharger I think you accidentally pushed an unrelated change to this branch. We recommend using separate branches for each PR, and not using main, to prevent this happening by accident.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger commented Oct 21, 2024

Copy link

Copy Markdown

Contributor Author

Oops, that was an accident...thought I was on a different branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger added 2 commits

October 21, 2024 15:02


          Revert "Add bootloader to DeviceInformationService.h"

814ab25

This reverts commit f3f0fd5.


          Revert "Add bootloader to DeviceInformationService.cpp"

0b006a0

This reverts commit 35570ed.

liamcharger commented Oct 22, 2024

Copy link

Copy Markdown

Contributor Author

I feel like maybe you could use the picture we use for the recovery firmware, that's on a black background.

@FintasticMan do you know where I can get an image resource of the recovery firmware picture?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger requested a review from mark9064

October 22, 2024 16:17

mark9064 reviewed

Oct 22, 2024

View reviewed changes

mark9064 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare the colour of the centre picture to what's currently on the README

I'm assuming Fin means this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

liamcharger commented Oct 22, 2024

Copy link

Copy Markdown

Contributor Author

Ok, I'll do that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

liamcharger added 5 commits

October 23, 2024 11:35


          Delete doc/logo/watchface_collage.png

9fba74e


          Add files via upload

ad2d5d6


          Delete doc/logo/watchface_collage.png

50372e4


          Add files via upload

4ab7536


          Replace collage with correct image

b416486

liamcharger commented Oct 23, 2024

Copy link

Copy Markdown

Contributor Author

@FintasticMan @mark9064 @JF002 all done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FintasticMan approved these changes

Oct 23, 2024

View reviewed changes

FintasticMan left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If you update it to the latest main I'll merge it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

liamcharger commented Oct 23, 2024

Copy link

Copy Markdown

Contributor Author

Great! The branch is already up to date, though.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FintasticMan commented Oct 23, 2024

Copy link

Copy Markdown

Member

Ah, sorry, I had rebase merge selected rather than squash merge.

liamcharger reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FintasticMan merged commit 879bdcc into InfiniTimeOrg:main

Oct 23, 2024

jmlich pushed a commit to jmlich/InfiniTime that referenced this pull request

Dec 22, 2024


          README: Header redesign (InfiniTimeOrg#2032)

f9a8a47

* Reformat README.md

* Update README.md

* Add files via upload

* Add files via upload

* Add new README.md header image

* Remove unnecessary <br> tag

* Scale watchface logo down; add downloads badge

* Remove unnecessary <br> tag

* Add <br> tag to maintain spacing consistency

* Remove incorrect link

* Add watchface logo with dark logo

* Replace logo image with dark version

* Add files via upload

* Add header image

* Fix row spacing in header image

* Remove unnecessary <br> tag

* Add corner radius to header image

* Add files via upload

* Update image background

* Add reference to InfiniTimeExplorer

* Remove unnecessary image

* Remove unnecessary image

* Remove unnecessary images

* Rename watchface_collage_no_shadow.png to watchface_collage.png

* Update header image URL

* Remove unnecessary <br> tag

* SPI transaction hooks

* Remove task to notify

* Refactor display WriteToRam

* Use functional abstraction for hooks

* Refactor lambdas

* Avoid storing lambda

* Rename to pre-transaction hook

* Use FreeRTOS delay instead of spinning the CPU

* Apply display driver datasheet delays

* Move includes back

* Include task header (Fixes sim)

* Make chime vibrate twice

* Remove commit from main

* README: improve wording

* Add bootloader to DeviceInformationService.cpp

* Add bootloader to DeviceInformationService.h

* Revert "Add bootloader to DeviceInformationService.h"

This reverts commit f3f0fd5.

* Revert "Add bootloader to DeviceInformationService.cpp"

This reverts commit 35570ed.

* Delete doc/logo/watchface_collage.png

* Add files via upload

* Delete doc/logo/watchface_collage.png

* Add files via upload

* Replace collage with correct image

---------

Co-authored-by: mark9064 <[email protected]>

Reviewers

mark9064

mark9064 left review comments

NeroBurner

NeroBurner approved these changes

FintasticMan

FintasticMan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

documentation

Improvements or additions to documentation

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

liamcharger commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rambonette commented Mar 5, 2024

Uh oh!

liamcharger commented Oct 1, 2024

Uh oh!

tituscmd commented Oct 1, 2024

Uh oh!

mark9064 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FintasticMan commented Oct 19, 2024

Uh oh!

liamcharger commented Oct 19, 2024

Uh oh!

FintasticMan commented Oct 19, 2024

Uh oh!

FintasticMan commented Oct 21, 2024

Uh oh!

liamcharger commented Oct 21, 2024

Uh oh!

liamcharger commented Oct 22, 2024

Uh oh!

mark9064 left a comment

Choose a reason for hiding this comment

Uh oh!

liamcharger commented Oct 22, 2024

Uh oh!

liamcharger commented Oct 23, 2024

Uh oh!

FintasticMan left a comment

Choose a reason for hiding this comment

Uh oh!

liamcharger commented Oct 23, 2024

Uh oh!

FintasticMan commented Oct 23, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liamcharger commented Feb 28, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.