GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bluetooth setting : emit the radio toggle message only if the value of the setting changed by JF002 · Pull Request #2037 · InfiniTimeOrg/InfiniTime

Conversation

@JF002

@JF002 JF002 commented Mar 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Emit the message BleRadioEnableToggle to DisplayApp only if the enable state of the radio has actually changed.

This fixes an issue where the BLE connected logo would disappear when opening and closing the BLE setting (without changing it) while InfiniTime was already connected to a companion app.

This fix is based on the work done by @JustScott in #1972 and also thanks to the very detailed description of the issue by @rambonette in #1961.

I think this fix makes more sense since we do not actually need to call NimbleController::EnableRadio() again if the radio was previously enabled and need to stay enabled.

This change also removed the need to send the message in SettingBluetooth::~SettingBluetooth() by capturing this in the lambda (which is called in CheckboxList::~CheckboxList() which is destroyed before SettingBluetooth.

What do think about this @JustScott?

Fixes #1961.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rambonette and JustScott reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@github-actions

github-actions Bot commented Mar 14, 2024

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 377384B 0B
data 940B 0B
bss 63540B 0B
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JF002 @JustScott
Emit the message BleRadioEnableToggle to DisplayApp only if the enabl…
d3e5410 
…e state of the radio has actually changed.

This fixes an issue where the BLE connected logo would disappear when opening and closing the BLE setting (without changing it) while InfiniTime was already connected to a companion app.

Co-authored-by: JustScott <[email protected]>
@JF002
JF002 force-pushed the emit-ble-radio-toggle-only-if-setting-changed branch from 2458aef to d3e5410 Compare March 14, 2024 20:05
@rambonette

rambonette commented Mar 14, 2024

Copy link
Copy Markdown

Glad to help! Wish I had more time to tackle these problems myself 😵‍💫
JF002 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JustScott

JustScott commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Glad I could help @JF002! Your solution address the issue at its core and works great on my pinetime!
JF002 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JustScott
JustScott approved these changes Mar 15, 2024
View reviewed changes
@JustScott JustScott mentioned this pull request Mar 15, 2024
Fix bluetooth setting not actually changing bluetooth radio settings. #1972
Closed
FintasticMan
FintasticMan approved these changes Mar 15, 2024
View reviewed changes
@FintasticMan
FintasticMan merged commit 4ca2112 into main Mar 15, 2024
@FintasticMan FintasticMan added this to the 1.15.0 milestone Mar 15, 2024
Eve1374 pushed a commit to Eve1374/InfiniTime that referenced this pull request May 30, 2024
@JF002 @JustScott @Eve1374
Emit the message BleRadioEnableToggle to DisplayApp only if the enabl…
cbc16cd 
…e state of the radio has actually changed. (InfiniTimeOrg#2037)

This fixes an issue where the BLE connected logo would disappear when opening and closing the BLE setting (without changing it) while InfiniTime was already connected to a companion app.

Co-authored-by: JustScott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FintasticMan FintasticMan FintasticMan approved these changes
+1 more reviewer
@JustScott JustScott JustScott approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Bluetooth setting is behaving abnormally

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JF002 @rambonette @JustScott @FintasticMan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.