GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — Fix EOL related build issues on Windows by madmini · Pull Request #2077 · InfiniTimeOrg/InfiniTime Conversation
Contributor
Proper fix for #1275 that does no longer require manual intervention. On Windows, git has With this change, I can build using docker on Windows 11 as follows: git clone https://github.com/madmini/InfiniTime.git --branch fix/eol-on-windows cd InfiniTime git submodule update --init docker run --rm -it -v ${PWD}:/sources infinitime/infinitime-build Without the change, the build fails with an error that matches the one described in #1275: Note: when changing between branches with varying git clone https://github.com/madmini/InfiniTime.git # CRLF line endings git checkout fix/eol-on-windows # still CRLF line endings git rm --cached -r . git reset --hard # LF line endings
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
looking good. No change in behavior on supported platforms (i.e. Linux) and possible fix for Windows builds. Just suggesting a few comments for future "us" to know why we don't have native line endings
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
f06149e to
a44d00a
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
looking good. I'm scheduling for 1.16.0 as 1.15.0 feels close
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
If you rebase this onto main the CI should work now #2166 is merged |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a44d00a to
071c9ce
Compare
done |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
only affects windows users
add reminder why this is necessary directly to file Co-authored-by: NeroBurner <[email protected]>
071c9ce to
6e09d57
Compare
Prevent line endings from getting normalised to CRLF Co-authored-by: NeroBurner <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.