GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pride flag watchface by Aperture32GLaDOS · Pull Request #2201 · InfiniTimeOrg/InfiniTime

Conversation

@Aperture32GLaDOS

@Aperture32GLaDOS Aperture32GLaDOS commented Dec 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds a new watch face with the trans flag as a background

Features

  • A new watch face, featuring the mlm, trans, bi, and wlw flags
  • Bluetooth indicator in the top right
  • Long day names

Images

image
image
image
image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marigoldfish, Athozus, and tituscmd reacted with thumbs up emoji marigoldfish reacted with hooray emoji marigoldfish, NitroNils, dozadoesit, NeroBurner, and lucaswerkmeister reacted with heart emoji
All reactions
  • 👍 3 reactions
  • 🎉 1 reaction
  • ❤️ 5 reactions
@Aperture32GLaDOS
Added trans watch face
0a48fbc
@github-actions

github-actions Bot commented Dec 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Patched source files with fixed formatting
7e2f2a1
@mark9064 mark9064 added the new watchface This thread is about a new watchface label Dec 22, 2024
@marigoldfish

marigoldfish commented Dec 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Love it! 🏳️‍⚧️😁 You are a very cool person, I'm going to be using this for a while!

Edit to add: I hope you find $20 on the ground or something similar fortunate and nice happens to you!

IMG_20241229_213604426~2

Aperture32GLaDOS, 3kh0, and sukhmel reacted with heart emoji
All reactions
  • ❤️ 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 reviewed Dec 30, 2024
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aperture32GLaDOS and marigoldfish reacted with heart emoji
All reactions
  • ❤️ 2 reactions
Comment thread src/displayapp/screens/WatchFaceTrans.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFaceTrans.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFaceTrans.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFaceTrans.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFaceTrans.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Implemented suggested changes
ee2e868
@Aperture32GLaDOS

Aperture32GLaDOS commented Dec 30, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the quick feedback! I've implemented those changes, hopefully everything's good now

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented Jan 3, 2025

Copy link
Copy Markdown
Member

All looks good to me! You couldn't have made review easier :)

I haven't had the chance to test on hardware yet and am away for now, but I should be able to test within a couple weeks time

Aperture32GLaDOS reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064 mark9064 added this to the 1.16.0 milestone Jan 3, 2025
@marigoldfish

marigoldfish commented Jan 4, 2025

Copy link
Copy Markdown

I have been using this daily, and I really like it, but I have a few small suggestions:

I adore the "You have mail." for notifications, but I dislike that it overlaps so severely with the battery percentage:

IMG_20241231_082654043~2

I think it might look better to have "mail." on its own line below, and move "You have" up a little bit so they're both centered vertically in the blue stripe.

(The 90's kid in me really wants it to read "You've got mail," like AOL, but that's not a request for a change, just a nostalgic observation)

My other suggestion is to name the watch face more specifically as "Trans Flag" instead of just "Trans."

IMG_20250103_220544316_HDR~2

Like I said, very very small suggestions. The other 99% of this watchface is grand!

Aperture32GLaDOS reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS

Aperture32GLaDOS commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

I definitely agree with the notification and the name. Fortunately, these are just one-line fixes so it's not that hard to change.
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Made notification display not overlap battery level; changed name fro…
9b8df1f
…m "Trans" to "Trans Flag"
marigoldfish
marigoldfish reviewed Jan 4, 2025
View reviewed changes

@marigoldfish marigoldfish left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I can nitpick, I think "Mail" should be lowercase. But this looks really good 😁

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Aperture32GLaDOS

Aperture32GLaDOS commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

Good spot, I'll fix that

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Changed Mail to mail in notification
bb388ef
@marigoldfish

marigoldfish commented Jan 4, 2025

Copy link
Copy Markdown

You are an incredibly awesome and speedy person! Thanks for implementing my suggestions, and so fast! I'll keep testing this daily for a while and let you know if I come across anything else 😁

Aperture32GLaDOS reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Merge remote-tracking branch 'upstream/main'
3c0ccf2
@marigoldfish

marigoldfish commented Jan 18, 2025

Copy link
Copy Markdown

Hello again, I noticed another little thing after using this watch face for a while.

Usually I keep my watch in 24 hour time, but I had reason to use 12 hour time today, and I noticed that both AM and PM show up as "M."

(I manually set the watch to 2am to get the second picture, I didn't stay up late 😜)

IMG_20250117_184147295~2
IMG_20250117_184236513~3

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS

Aperture32GLaDOS commented Jan 18, 2025

Copy link
Copy Markdown
Contributor Author

I think what's happening here is that the font used for the time doesn't have all the alphabet, if I change the font to something else it seems to work fine:
image
I've moved the AM/PM display to the day, since that uses a font which has all the alphabet
image

marigoldfish and sukhmel reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Moved AM/PM display to the day
e01e616
@marigoldfish

marigoldfish commented Jan 20, 2025

Copy link
Copy Markdown

That's an elegant fix! I like it!

Unfortunately, in addition to praise I also come bearing news of a new bug: it is displaying 24-hour time when I have 12-hour time enabled.

IMG_20250119_203002810~2

sukhmel reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS

Aperture32GLaDOS commented Jan 20, 2025

Copy link
Copy Markdown
Contributor Author

Aah, well at least that's an easy fix; it should all be working now
image

marigoldfish and sukhmel reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Fixed 12H mode displaying 24H times
879fb48
@NeroBurner

NeroBurner commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

could you update to/rebase onto the latest main branch. The toolchain won't run as the artifacts v3 job was deprecated by GitHub, and that is fixen in the current main branch

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Merge remote-tracking branch 'upstream/main'
56e7072
@Aperture32GLaDOS

Aperture32GLaDOS commented Feb 2, 2025

Copy link
Copy Markdown
Contributor Author

Yup, should be all good now

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rdub1a4

rdub1a4 commented Feb 10, 2025

Copy link
Copy Markdown

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

JustScott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JustScott

JustScott commented Feb 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Seems like this would wait for side loading. It may not fit the vision of "Only a minimal feature set in the flashed firmware". But, no biggy.

I dont understand why this watchface was added to the 1.16.0 milestone so quickly over the various other watchface PRs that have been sitting around for quite a long time?

docertabum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented Feb 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Mainly because it doesn't depend on any other PRs and was easy to review

Things get added to the milestone when we want to target including them this cycle. If a PR depends on lots of other refactoring for example, or has outstanding bugs that are taking time to resolve, then it usually won't be queued up for the next cycle until it's ready. InfiniTime generally lacks reviewers though, so what gets queued and what doesn't depends on whether someone's had time to look at it properly

Edit: also you're totally welcome to help with review or express support/interest in PRs in the comments, it helps with prioritising review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@NeroBurner

NeroBurner commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

totally optional: could you update the initial PR description to contain updated images for the currently implemented pride flags?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 reviewed Jun 16, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Sounds like my thoughts are pretty similar to @NeroBurner regarding duplication

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

NeroBurner
NeroBurner requested changes Jun 16, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions to make the build work again

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Aperture32GLaDOS and others added 3 commits June 17, 2025 13:53
@Aperture32GLaDOS
- Moved all flag-specific data into a new FlagData class
5cd30ac
- Implemented all suggested changes
@Aperture32GLaDOS
Merge branch 'main' into main
3fb52d9
@Aperture32GLaDOS
Fixed signedness error in background section for-loop
f314569
NeroBurner
NeroBurner reviewed Jun 17, 2025
View reviewed changes
Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

mark9064
mark9064 reviewed Jun 17, 2025
View reviewed changes
Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Renamed notificationIcon to notificationText, and changed security of…
d0217ba
… UseFlagData to private
mark9064
mark9064 reviewed Jun 17, 2025
View reviewed changes
Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Aperture32GLaDOS added 2 commits June 17, 2025 14:43
@Aperture32GLaDOS
Swapped out C-style casts for C++ style
b582d3d
@Aperture32GLaDOS
Changed UpdateScreen to private
5643c2e
mark9064
mark9064 approved these changes Jun 17, 2025
View reviewed changes

@mark9064 mark9064 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go!! The flags will never look right in AOD with only 8 colours but I'd like to make sure text at least stays readable. Would you be able to test it quickly? If not I can flash mine

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Aperture32GLaDOS

Aperture32GLaDOS commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, no worries - I'm flashing it now

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS

Aperture32GLaDOS commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

wlw
bi
mlm
trans
The time is legible on all of them, but on the trans watch the day and date are invisible - if it's an issue we could change all text to be black

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064

mark9064 commented Jun 17, 2025

Copy link
Copy Markdown
Member

I don't think it's a big issue - I'll leave whether white or black works better for the trans face to you :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS

Aperture32GLaDOS commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

In that case, I'd prefer to leave it as-is, with black for the time and white for everything else

mark9064 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064
mark9064 requested a review from NeroBurner June 17, 2025 15:31
NeroBurner
NeroBurner reviewed Jun 17, 2025
View reviewed changes
Comment thread src/components/settings/Settings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mark9064 mark9064 mentioned this pull request Jun 17, 2025
Watchface and app settings should be separate from the system settings #2314
Open
NeroBurner
NeroBurner requested changes Jun 17, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much constness, much wow 🤓

I found a way to have PrideFlagData in cpp file. See comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/components/datetime/DateTimeController.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

NeroBurner
NeroBurner reviewed Jun 17, 2025
View reviewed changes
Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Implemented suggested changes (moving PrideFlagData into cpp, making …
1c6d4f0
…constant variables const, and generally tidying up)
NeroBurner
NeroBurner reviewed Jun 18, 2025
View reviewed changes
Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Aperture32GLaDOS
Cleaned up constructor usage
8ae772f
NeroBurner
NeroBurner requested changes Jun 18, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one last const, and then I think we're good to go!

It's been lovely working with you on this MR @Aperture32GLaDOS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/displayapp/screens/WatchFacePrideFlag.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.

NeroBurner
NeroBurner approved these changes Jun 18, 2025
View reviewed changes

@NeroBurner NeroBurner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looking good. Thanks for the contribution and your great teamwork! I had fun reviewing and learning on this PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aperture32GLaDOS reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@Aperture32GLaDOS

Aperture32GLaDOS commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

Brilliant! Thanks all for the advice and feedback, it's been very helpful

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mark9064
mark9064 merged commit 4517fb8 into InfiniTimeOrg:main Jun 19, 2025
metaphys pushed a commit to metaphys/InfiniTime that referenced this pull request Mar 30, 2026
@Aperture32GLaDOS @metaphys
Pride flag watchface (InfiniTimeOrg#2201)
fc1d548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mark9064 mark9064 mark9064 approved these changes
@NeroBurner NeroBurner NeroBurner approved these changes
+1 more reviewer
@marigoldfish marigoldfish marigoldfish left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

new watchface This thread is about a new watchface

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Aperture32GLaDOS @marigoldfish @mark9064 @NeroBurner @rdub1a4 @JustScott @joseph58tech
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.